@amit-patel THX for your finding! I fixed this now. The compiler says it’s ok .
-
Pimatic & Node 8.0
pimatic-hap - pimatic HomeKit bridge
pimatic-echo - Amazon echo integration
pimatic-dash-button - Amazon dash button support
pimatic-alarm - pimatic alarm system
Like my work? Then consider a donation
Follow me: https://twitter.com/michaelkotten -
@michbeck100 btw, did you see this pull request I made in the core lib: https://github.com/pimatic/pimatic/issues/1084 ?
It’s a pretty simple fix, if you wanted to implement in your fork.
-
@michbeck100 BTW, you’re still referencing this before calling super()
Using this one as an example:
class LogActionProvider extends ActionProvider constructor: (@framework) -> super()
should be rewritten as
class LogActionProvider extends ActionProvider constructor: (framework) -> super() @framework = framework
Another approach would be to change the base ActionProvider class to
class ActionProvider constructor: (@framework) -> parseAction: (input, context) => throw new Error("Your ActionProvider must implement parseAction")
and then in all the extended classes you can just use:
class LogActionProvider extends ActionProvider constructor: (framework) -> super(framework)
-
@amit-patel Sorry but this is fine. See the link in your own comment: http://coffeescript.org/v2/#breaking-changes-super-this
class B extends A constructor: (@arg) -> super(@arg) # Throws a compiler error
but if you don’t pass this as parameter to the super class, its ok. So:
class B extends A constructor: (@arg) -> super() # compiles @arg.foo()
As I said, i compiled the whole project with the new coffeescript version
node_modules/coffeescript/bin/coffee -c .
pimatic-hap - pimatic HomeKit bridge
pimatic-echo - Amazon echo integration
pimatic-dash-button - Amazon dash button support
pimatic-alarm - pimatic alarm system
Like my work? Then consider a donation
Follow me: https://twitter.com/michaelkotten -
I stand corrected. Apologies.
-
@amit-patel Nevermind! Thanks for your findings.
pimatic-hap - pimatic HomeKit bridge
pimatic-echo - Amazon echo integration
pimatic-dash-button - Amazon dash button support
pimatic-alarm - pimatic alarm system
Like my work? Then consider a donation
Follow me: https://twitter.com/michaelkotten -
Hi there,
what is the status of Node 8.0 release. Is there made any progress?
If u need someone to test it, please let me know.
Greetings,
Ivan. -
@michbeck100 said in Pimatic & Node 8.0:
@mwittig did a short test with node v6 and v8 today. I found some glitches, had to update some dependencies but overall it doesn’t look too bad. Could you explain, what the biggest problems are?
BTW: if anyone wants to try: https://github.com/michbeck100/pimatic/tree/node_v8
I didn’t do any bigger testing, so be prepared that not everything will be working. Just make sure to do a clean install of pimatic.
As I wrote earlier there is a branch you can use for testing
pimatic-hap - pimatic HomeKit bridge
pimatic-echo - Amazon echo integration
pimatic-dash-button - Amazon dash button support
pimatic-alarm - pimatic alarm system
Like my work? Then consider a donation
Follow me: https://twitter.com/michaelkotten -
Node.js 10.x with long therm support has been released (https://medium.com/@nodejs/the-node-js-project-introduces-latest-release-line-node-js-10-x-bf07abfa9076)
Would it not make more sense to aim for the latest version instead?
Did anyone try to run pimatic with node v10 yet?
-
@momatic said in Pimatic & Node 8.0:
Node.js 10.x with long therm support has been released
Thats’s misleading. The announcement states, it “will become the new active Long Term Support release line”. According to the schedule LTS start is planned for October 2018. So, the LTS version for the next 6 months is v8.
EDIT: While v10 has already passed the development stages (v9), I expect it will require a few more weeks to mature, the new ABI in particular. The N-API is said to add ABI-stability which should simplify the job for maintainers of modules with native code integration. It is a bit of an irony Nodejs required 7 major releases as they say (btw, I am counting to get the ABI right, and that’s just a promise for now. We will see.
@momatic as @michbeck100 said earlier, his fork branch can be used for testing. So, feel to give it a try and report back with your findings. This will be highly appreciated.
"It always takes longer than you expect, even when you take into account Hofstadter's Law.", Hofstadter's Law
-
@michbeck100 I’d like to try out your node_v8 branch, but I don’t know how to install pimatic from a repo instead of using the npm.
I have done/tried the following steps:- Installed node v8.12.0
- Cloned pimatic branch node_v8
- Run install bash scripts
Could you please help me to get your version running?
-
How stable is it?
-
@temp pimatic itself was running the last time I tried. Main problem will be the plugins. Every single one must be updated I guess. But the changes are backwards compatible AFAIK.
pimatic-hap - pimatic HomeKit bridge
pimatic-echo - Amazon echo integration
pimatic-dash-button - Amazon dash button support
pimatic-alarm - pimatic alarm system
Like my work? Then consider a donation
Follow me: https://twitter.com/michaelkotten -
@momatic the install scripts are not needed.
$ sudo node node-modules/pimatic/pimatic.js
should do the trick. I’m not in front of my pc now, so I can’t try myself.
If you want to run it in the background then just replace your original pimatic folder with the branch, add your config.json and start with$ sudo service pimatic start
I guess that should do the trick. Please just rename your original pimatic installation to be sure
pimatic-hap - pimatic HomeKit bridge
pimatic-echo - Amazon echo integration
pimatic-dash-button - Amazon dash button support
pimatic-alarm - pimatic alarm system
Like my work? Then consider a donation
Follow me: https://twitter.com/michaelkotten -
@michbeck100 said in Pimatic & Node 8.0:
@temp pimatic itself was running the last time I tried. Main problem will be the plugins. Every single one must be updated I guess. But the changes are backwards compatible AFAIK.
Why not writing all people to change their plugin code to node v8.0???
-
@michbeck100 said in Pimatic & Node 8.0:
@temp pimatic itself was running the last time I tried. Main problem will be the plugins. Every single one must be updated I guess. But the changes are backwards compatible AFAIK.
Could you explain more detailed why you think so? Why every single plugin needs to be updated?
Is there already an overview with working and not working plugins so that it would be easier for others to test whats working? -
@dasmaetthes If you look at this commit for example, you’ll see that node version > 4 doesn’t “compile” if some things are missing. Most of the changes i had to do in pimatic to get it running with node 8 were like this.
And you’ll find these problems in most, if not all plugins, too. But these changes still work with node 4, thats why i think that we don’t need special versions for node 4 and node 8.Is there already an overview with working and not working plugins so that it would be easier for others to test whats working?
The overview is pretty easy, AFAIK there is no plugin that incorporates the needed changes, yet.
pimatic-hap - pimatic HomeKit bridge
pimatic-echo - Amazon echo integration
pimatic-dash-button - Amazon dash button support
pimatic-alarm - pimatic alarm system
Like my work? Then consider a donation
Follow me: https://twitter.com/michaelkotten -
So the main problem is that no one started yet to update his plugins for node.js > 4. Pimatic itself would work?
-
@michbeck100 said in Pimatic & Node 8.0:
@mwittig did a short test with node v6 and v8 today. I found some glitches, had to update some dependencies but overall it doesn’t look too bad. Could you explain, what the biggest problems are?
BTW: if anyone wants to try: https://github.com/michbeck100/pimatic/tree/node_v8
I didn’t do any bigger testing, so be prepared that not everything will be working. Just make sure to do a clean install of pimatic.
Like i said, everyone is free to test my branch for node 8, i didn’t have the time to test it, yet.
pimatic-hap - pimatic HomeKit bridge
pimatic-echo - Amazon echo integration
pimatic-dash-button - Amazon dash button support
pimatic-alarm - pimatic alarm system
Like my work? Then consider a donation
Follow me: https://twitter.com/michaelkotten -
@michbeck100 said in Pimatic & Node 8.0:
Could you explain, what the biggest problems are?
As said earlier, I think the biggest hurdle is to partially rewrite the plugin management which currently relies on deprecated features of Npm 2, like the hierarchical placement of dependencies in the file system. May be it is not too bad, but it needs a closer look and thought.
How about the mobile frontend? Did you look at this, too? When I tried pimatic with node 8 based on your branch it seemed to work fine, but obviously it was just running the compiled/transformed JS code. So, when this is built from source I expect one will also run into some issues. Some packages use by the front are completely EOL and the code needs to be ported/migrated to alternative packages.
If you have some to work on this in the future may be we can liaise at some point and jointly work on this. I think I can find some days in November to work on this.
"It always takes longer than you expect, even when you take into account Hofstadter's Law.", Hofstadter's Law