Plugin for WIFI controlled LED light (IWY-Light)

---

First of all, nice work

I used your plugin with some code & a pcb that I designed a while ago to connect my cheap ebay rgb ledstrips to my pimatic installation using a esp8266 wifi chip. Basically, I implemented the wifi370 protocol on the esp8266 and used PWM outputs of the chip to drive the ledstrip. Therefore I was able to use your plugin without any modifications, which is nice.

A demo video here: http://youtu.be/MzmGHIzuEzY

Once I get some more time I’ll write up a blogpost with more detailed info on the PCB/esp8266 part. Code is up on github here if anyone is interested in esp8266 stuff.

Only thing in the plugin that I can think of that could use improvement is better touchscreen support for the color picker. Currently you have to drag the dot or the slider, clicking on a certain spot doesn’t work (tested on windows (phone) and android (chrome))
(Personally I like the Dummy3 option as proposed by Pimagical - although it has no ‘white’ option - it seems to be most straightforward and easy to use (no popup))

Thats strange:
The config says “Error: connection timeout” but i just added the device to my gui and its working.

@auspex-nl Wow that is pretty cool. I will order an esp8266 and try it on my own.

@thymian “Error: connection timeout” means that a command to the light device was running into an timeout. This could be caused due to network issues or because the device is simply switch off. But I saw also that this error often appears during the start of pimatic, you can consider this as a bug. I will try to fix it soon.

@auspex-nl what you did is very great, looking forward for the schematic
I do have a led strip with a RF controller but not very satisfied with the controller itself, i also have few esp8266 so…

@philip1986 I have filed a new PR for the Milight integration which is is based on your refactoring work. For details see https://github.com/philip1986/pimatic-led-light/pull/7#issuecomment-100688865

EDIT: See also my feature request poll for a Milight color slider - http://forum.pimatic.org/topic/446/implement-color-slider-for-milight-rgbw-leds

@philip1986 i just made a few modifications for milight, and put them in a pull request.

I did notice that there are still some pull requests open? are they still relevant?

i would recommend cleaning up any irrelevant pull requests. Else there is a chance that people are doing the same thing twice…

For the Branch multi devices, when do you expect to put it to master? i think the milight part works well.
Or is it better to wait for a new UI?
@mwittig Did you already have a finished UI, or was it just a concept?

@Fjux See also my pending PR. May be you try to merge it into you PR.

@mwittig said:

@Fjux See also my pending PR. May be you try to merge it into you PR.

I do not know how I can merge into a PR. Where should I look?

@Fjux It is basically the same as merging an upstream repository. See https://help.github.com/articles/merging-an-upstream-repository-into-your-fork for example. Rather than using the original own git you can use https://github.com/mwittig/pimatic-led-light.git as this is identical with my PR.

@Fjux said:

Did you already have a finished UI, or was it just a concept?

As the feature request has not received any votes yet I have not spent more work on this yet.

@mwittig Oh ofcourse,
didn’t think about that thanks

Sorry Guys, I didn’t have time to the take care about the PR of @mwittig. I try to do it now and once this is done I will check out the PR from @Fjux.

@mwittig Good job. The code looks well and the IwyLight device is behaving like before. I merged your PR, but I will wait for a new release until @Fjux is done.

@Fjux I reopened your PR against master, now you should catch up with the master branch.
I also add one comment about setting white mode in case of color is set to white. For me white mode and white in color mode are different things. And I would prefer to don’t mix it up. But maybe I am wrong with this, any other opinions about this??

@philip1986 I have made some additions to the pimiatic-led-light plugin to support Blinkstick. It have been working great for a couple of days: https://github.com/tester22/pimatic-led-light
Please merge the pull request when possible.

@tester22 I merged you PR, good job!
I merged also the PR from @Xento to support MilightRF24 and published the changes also on npm. @sweetpi can you please update the homepage arcorrding to https://www.npmjs.com/package/pimatic-led-light version 0.1.0.

I think it is great idea to support different types of led light through a single control interface and I highly appreciate the contribution made by various developers. What I don’t like is to provide this as a single plugin as this is contributing to bloat of dependencies. The list of indirect dependencies is breath-taking. These dependencies will be loaded into memory no matter which led light used. If you have multiple plugins written this way this may cause a serious bottleneck and stability issues. For this reason I would like to suggest a split up of the plugin into three plugin plus a common base package. I think this is fairly easy to do and I am happy to undertake this effort.

@mwittig I see your point. How would you provide the shared code to all plugins? I see there only to options, one is to include it to pimatic core and the other one is to have a abstract plugin repo for this purpose. Ok there is also the third options to just duplicate the shared code in each plugin, but this would be fairly unclean.

This all looks very good. I started wondering if its possible to also include Philips hue in this plugin?

@Cryonic90 Yes, should be relatively easy since they have an official API (http://www.developers.meethue.com/documentation/getting-started). I you like fell free to contribute

@philip1986 said:

How would you provide the shared code to all plugins?

This is fairly simple and straightforward. I would wrap-up the BaseLedLight, ColorActionHandler, and ColorActionProvider classes and the “ui” bit into a node package and require this in the plugin implementation. This way, you end up with one plugin per LED-technology with a common base implementation. I think this is better as I suppose most user just use one or two LED light technologies. Note, beyond a package required by multiple plugin will be only loaded once if it is the same version.