Customize - ioBroker.pimatic

---

@bertreb said in Customize - ioBroker.pimatic:

In the connect function of main.js the websockets url is http://ip:port/?username=<username>&password=<password>
This url can’t be used for http requests!

See its soo confusing

And the only time there go to the normal Path for the API is in Line 72 with:

“var link = getUrl + ‘api/device/’ + objects[id].native.control.deviceId + ‘/’ + objects[id].native.control.action + ‘?’ + objects[id].native.name + ‘=’ + state.val;”

but this is only a “State”-Monitor function … so where there get all the devices?

With a Dummy Temperatur Sensor it is working fine because its device but there is no dummy devices for Battery-States, Roborock cleaned m², filter % and stuff like that … so i created my own variables for it and use the VariablesDevices for it.

I will investigate further tomorrow

@bertreb said in Customize - ioBroker.pimatic:

I will investigate further tomorrow

no hurry … its works in the moment with insane big blocky scripts there that over the top that the browser will some times crash when you edit it … as always i push things that are not made for it to the limits …

Have a good night, dude

Hi, the info on the Pimatic variables is available in ioBroker but it has to be integrated in the ioBroker logic. Somebody with experiance of writing adapters should be able to do that.
What i could do is, create a Plugin(+device) with all the standalone (non device) Pimatic read-write variables in it. Such a device can be included and used in ioBroker already.
It automates the creation of a variablesdevice for the device independent variables

Hey,

first big thanks for your effort and your offer for the Plugin maybe i will come back to it.

But because im a strange guy and i hate “that does not work” … i just do what a no0b dev do Playing around and see whats happend.

So just change every “Device” in the “SyncDevices” funktion with “Variable” as my first plan

I know now this part will create the “Main-Folder” “Devices” / “Variables” and the “folders” for the “Devices / Varaible” it self:
function syncVariables(variables, callback) {
var objs = [];
var _states = [];
for (var d = 0; d < variables.length; d++) {
var localObjects = [];
var variable = variables[d];
adapter.log.debug('Handle Variables: ’ + JSON.stringify(variable));
var obj = {
_id: adapter.namespace + ‘.Variables.’ + variable.id,
common: {
name: variable.name
},
type: ‘channel’
};
objs.push(obj);

And it looks then like that:

then i changed the line “adapter.log.debug('Handle Variables: ’ + JSON.stringify(variable));” to “…log.Info” to get a littlebit more overview over the massiv log from the adapter. Now i know whats in the Variable “variable” its just the json string and all the Infos.

2020-03-04 18:22:29.620 info (3027) Handle Variables: {“name”:“zwave-wohnzimmerpir-temperatur”,“readonly”:false,“type”:“value”,“value”:22.1,“unit”:""}
pimatic.1 2020-03-04 18:22:29.620 info (3027) Handle Variables: {“name”:“zwave-wohnzimmerpir-luminance”,“readonly”:false,“type”:“value”,“value”:0,“unit”:""}
pimatic.1 2020-03-04 18:22:29.620 info (3027) Handle Variables: {“name”:“zwave-wohnzimmerpir-battery”,“readonly”:false,“type”:“value”,“value”:100,“unit”:""}
pimatic.1 2020-03-04 18:22:29.619 info (3027) Handle Variables: {“name”:“zwave-badpir-battery”,“readonly”:false,“type”:“value”,“value”:100,“unit”:""}
pimatic.1 2020-03-04 18:22:29.619 info (3027) Handle Variables: {“name”:“zwave-badpir-temperatur”,“readonly”:false,“type”:“value”,“value”:21.2,“unit”:""}
pimatic.1 2020-03-04 18:22:29.619 info (3027) Handle Variables: {“name”:“zwave-badpir-luminance”,“readonly”:false,“type”:“value”,“value”:0,“unit”:""}
pimatic.1 2020-03-04 18:22:29.619 info (3027) Handle Variables: {“name”:“zwave-flurpir-battery”,“readonly”:false,“type”:“value”,“value”:100,“unit”:""}

But in the moment it will just create one entry and see its “undefined”, but i think that cant be so hard to move on. …

Interesting, from where do call the syncVariables function

@bertreb

just under the SyncDevices

Soo now i have this:

Its because there use variable “d” for the loop but the variable wars already used by the device-Sync … so you have to null it or i just change the “d” to a “v”

for (var v = 0; v < variables.length; v++) {
var localObjects = [];
var variable = variables[v];

then it will just create all variables, the next step wars this “undefined” thats because this line:
_id: adapter.namespace + ‘.Variables.’ + variable.id;

In the original its “device.id” and i dont know in the moment not if this a default by iobroker? But it cant be because as far i know if you define “device” as variable there cant only this one variable. So i just changed it from “.id” to “.name” because i know “variables.name” has a values.

The Next step are to filter out every “readonly” and to get the values and then get the sync to work, but i think this needs a change in the states function!?!

@tehmilcho said in Customize - ioBroker.pimatic:

@bertreb

just under the SyncDevices

But than you call syncVariables(devices) with devices as parameter?

@bertreb said in Customize - ioBroker.pimatic:

@tehmilcho said in Customize - ioBroker.pimatic:

@bertreb

just under the SyncDevices

But than you call syncVariables(devices) with devices as parameter?

Ah sorry … i call it just under “client.on(‘variables’, function (variables)” before “syncStates” but i think it dosnt matter where you call it.

And no with “Variables” as Parameter.

“syncVariables(variables)”

That a logical place. I try to reproduce your solution.

@bertreb https://jsfiddle.net/7qLf8y1m/ there is just my Main.js

Done

function syncVariables(variables, callback) {
    var objs = [];
    var _states = [];
    
    for (var v = 0; v < variables.length; v++) {
        var localObjects = [];
        var variable = variables[v];
        if (variable.readonly == false) {
        adapter.log.debug('Handle Variables: ' + JSON.stringify(variable));
        var obj = {
            _id: adapter.namespace + '.Variables.' + variable.name,
            common: {
                name: variable.name,
                read: true,
                write: true,
            },
            type: 'state'
        };
        _states.push({
                    _id: adapter.namespace + '.Variables.' + variable.name,
                    val: {
                        ack: true,
                        val: variable.value,
                    }
        });
        objs.push(obj);
       }
    }
    var ids = [];
    for (var j = 0; j < objs.length; j++) {
        ids.push(objs[j]._id);
        objects[objs[j]._id] = objs[j];
    }
    syncObjects(objs, function () {
        syncStates(_states, function () {
            callback && callback(ids);
        });
    });
} 

Now i have the Variables and the values but the sync seems not to work in the moment

And i dont know what is this for:

   var ids = [];
    for (var j = 0; j < objs.length; j++) {
        ids.push(objs[j]._id);
        objects[objs[j]._id] = objs[j];
    }

If you leave that last part out. I think nothing is displayed and put into the ioBroker system

i tired just changing “j” to “vJ” because its like the other “for”-loops. In the moment the Adapater crashes when i change a value. Because “control” is not defined.

host.leetwerkiobroker	2020-03-04 20:21:03.138	info	Restart adapter system.adapter.pimatic.1 because enabled
host.leetwerkiobroker	2020-03-04 20:21:03.138	info	instance system.adapter.pimatic.1 terminated with code 0 (NO_ERROR)
host.leetwerkiobroker	2020-03-04 20:21:03.138	error	Caught by controller[0]: at processImmediate (timers.js:658:5)
host.leetwerkiobroker	2020-03-04 20:21:03.137	error	Caught by controller[0]: at tryOnImmediate (timers.js:676:5)
host.leetwerkiobroker	2020-03-04 20:21:03.137	error	Caught by controller[0]: at runCallback (timers.js:705:18)
host.leetwerkiobroker	2020-03-04 20:21:03.137	error	Caught by controller[0]: at Immediate.setImmediate (/opt/iobroker/node_modules/iobroker.js-controller/lib/adapter.js:4852:34)
host.leetwerkiobroker	2020-03-04 20:21:03.137	error	Caught by controller[0]: at Adapter.emit (events.js:198:13)
host.leetwerkiobroker	2020-03-04 20:21:03.137	error	Caught by controller[0]: at Adapter.<anonymous> (/opt/iobroker/node_modules/iobroker.pimatic/main.js:42:64)
host.leetwerkiobroker	2020-03-04 20:21:03.137	error	Caught by controller[0]: TypeError: Cannot read property 'control' of undefined
pimatic.1	2020-03-04 20:21:02.618	info	(3890) Terminated (NO_ERROR): Without reason
pimatic.1	2020-03-04 20:21:02.618	info	(3890) terminating
pimatic.1	2020-03-04 20:21:02.612	info	(3890) cleaned everything up...
pimatic.1	2020-03-04 20:21:02.612	info	(3890) disconnected 

you need to change j to vJ 6 times!

@bertreb said in Customize - ioBroker.pimatic:

you need to change j to vJ 6 times!

yep i know … but i think is now a problem maybe of the “sync”-function or of this “Iobroker” stuff, there some other Attributes that there give to the devices:

For example:
obj.common.role = ‘indicator.battery’;
obj.native.mapping = {‘ok’: false, ‘low’: true};
obj.common.type = ‘boolean’;
obj.common.states = {false: ‘ok’, true: ‘low’};

                     native: {
                            name: p,
                            control: {
                                action: action.name,
                                deviceId: device.id
                            }

maybe i miss some of them… i found this https://github.com/ioBroker/ioBroker/blob/master/doc/SCHEMA.md maybe this will help to understand

Okay … Progress

function syncVariables(variables, callback) {
    var objs = [];
    var _states = [];
    
    for (var v = 0; v < variables.length; v++) {
        var localObjects = [];
        var variable = variables[v];
        if (variable.readonly == false) {
        adapter.log.debug('Handle Variables: ' + JSON.stringify(variable));
        var obj = {
            _id: adapter.namespace + '.Variables.' + variable.name,
            common: {
                name: variable.name,
                read: true,
                write: true,
            },
            native: {
                control: {
                    action: 'set ' + variable.name + ' to',
                    deviceId: variable.name
                }
            },
            type: 'state'
        };
        _states.push({
                    _id: adapter.namespace + '.Variables.' + variable.name,
                    val: {
                        ack: true,
                        val: variable.value,
                    }
        });
        objs.push(obj);
       }
    }
    var ids = [];
    for (var vj = 0; vj < objs.length; vj++) {
        ids.push(objs[vj]._id);
        objects[objs[vj]._id] = objs[vj];
    }
    syncObjects(objs, function () {
        syncStates(_states, function () {
            callback && callback(ids);
        });
    });
}

now it will not crash but gives out this Error:

pimatic.1	2020-03-04 20:45:44.305	warn	(3995) Cannot write "pimatic.1.Variables.movement_time_bad": {"success":false,"message":"device not found: movement_time_bad"}

And this is the firsttime pretty logic because its the response from Pimatic RESTAPI … and of cause he cant find it as a device because its a variable

Yes, in Pimatic its an attribute of a device OR a deviceless variable! You need for the device-attribute variables always the deviceId.attribute-name