pimatic-mysensors and node v10
@djmvt said in https://forum.pimatic.org/topic/4746/pimatic-telegram-1-1-14/16 there is a PR waiting to include node v10 compatibility for pimatic-mysensors.
I am not sure if the plugin owner is still active. IT is relatively easy to deploy a “new” plugin as a clone of mysensors including the PR to make node v10 compatibility available. Happy to do so, but I am not using mysensors myself or equipped to provide support/maintenance.
Anyone who could take this on?
"Screw the captain. It's the engineer running the ship!"
pimatic-telegram, pimatic-tts, pimatic-woox, pimatic-lg-smart-tv, pimatic-spotify, pimatic-wakeuplight and some not-announced plugins
I contacted the plugin dev @Dheeraj some weeks ago. He responded that he would try to find some time and test the PR. Perhaps you can contact him also.
Introducing a clone plugin could be an option if it takes to much time. In my opinion the plugin page on the Pimatic site needs a little clean up before putting to many clone’s there. Because now active node v10 compatible plugins are on the same list as obsolete one. For (new) user not an attractive way to search plugins.
@bertreb said in pimatic-mysensors and node v10:
In my opinion the plugin page on the Pimatic site needs a little clean up before putting to many clone’s there. Because now active node v10 compatible plugins are on the same list as obsolete one. For (new) user not an attractive way to search plugins.
Agree. It would not be the preferred way…
"Screw the captain. It's the engineer running the ship!"
pimatic-telegram, pimatic-tts, pimatic-woox, pimatic-lg-smart-tv, pimatic-spotify, pimatic-wakeuplight and some not-announced plugins
@bertreb said in pimatic-mysensors and node v10:
I contacted the plugin dev @Dheeraj some weeks ago. He responded that he would try to find some time and test the PR. Perhaps you can contact him also.
@Dheeraj has merged the PR about two weeks ago, but to me it is not clear whether or not he had the opportunity to sufficiently test the changes.
As it is possible to install plugins from github master it’ll great of some users are willing to test this on one or more of the node.js versions we currently support. Maybe I can also find some time to take a stab on this during my holidays. The hurdle for me is to setup a mysensor device first as I am not using mysensors at the moment. Once we have confidence the changes are good to go I can publish a new package version.
For the longer term perspective we need to find a new maintainer for the plugin. In the past @sweebee as been active on this, but unfortunately he seems to be very busy these days.
Voluntary testers, please see also https://forum.pimatic.org/topic/1114/updated-how-to-install-a-plugin-from-github-using-npm-or-git
"It always takes longer than you expect, even when you take into account Hofstadter's Law.", Hofstadter's Law
@mwittig, picking up the node 10 compatibility of MySensor is good news!
I volunteer to test the merged master version of Mysensors.
On 11-3-2018 a development branch was created from the master, with some changes on the 18th. What about those changes?
@bertreb said in pimatic-mysensors and node v10:
On 11-3-2018 a development branch was created from the master, with some changes on the 18th. What about those changes?
I also noticed this. The changes are minimal, but I’ll merge them into master
https://github.com/DheerajKhajuria/pimatic-mysensors/commit/a3322f191496b14142e9c8a45d46cb9ccb93e81c
"It always takes longer than you expect, even when you take into account Hofstadter's Law.", Hofstadter's Law
I did some tests with the master branch of MySensors.
On my node 4.6.2 system the install didn’t succeed. Got an error on missing @serialport/parser-readline. On my node v10.7.0 system the master branch installed without problems.
I created a pull request with a proposed fix, that can be tested.
UPDATE: @Dheeraj committed the change to the master branch. If you want to use/test it install MySensors from the master branch. This is not the default branch! so use the ‘-b master’ option (see instruction)
i have clone it from github. how can i compile it with serialport? @bertreb
If you cloned the master branch, then you go into the director pimatic-mysensors and run npm install. Al the dependencies (incl serialport) will be installed automatically.
If you already had mysensors installed you should delete the pimatic-mysensors directory first and make a copy first (to rollback if needed).
Is this enough info?
jep! Thx, it is install now.
