New plugin [pimatic-datetime]
@mwittig said in New plugin [pimatic-datetime]:
I believe moment.js has quiet a few design flaws. From the documentation my understanding is the isoWeekday() function returns a number in the range 1…7 while weekday() returns a number in the range 0…6.
My suggestion is to let dayOfWeek be moment().weekday() + 1
"It always takes longer than you expect, even when you take into account Hofstadter's Law.", Hofstadter's Law
Okay, I thought starting with 0 is only for IsoWeekDay.
Well, then I will add in all cases 1 because it is easier to understand for the user in my opinion.
I would say, the work is done:
released version 0.1.0
I got a feature request from a friend. He wants to know if it is weekend. I think I will add this too.
@saxnpaule said in New plugin [pimatic-datetime]:
He wants to know if it is weekend. I think I will add this too.
Most Google / StackOverflow hits are suggesting to use either the result of Date.getDay() or moment.weekDay() and regard 0and 6 as weekend. That’s poor, however, as it does not take into account that the first weekday can differ depending on the locale set. Thus it is better to use the following:
isWeekend: () ->
moment.isoWeekday() > 5
EDIT: This may look wrong at a first glance. However, bear in mind that the isoWeekday() result ranges from 1 to 7.
"It always takes longer than you expect, even when you take into account Hofstadter's Law.", Hofstadter's Law
As isoWeekDay doesn’t care about the locale it should be quite easy. IsoWeekDay 6/7 are weekend. That was my plan to implement this.
version 0.1.1 released 2018-03-24
@SaxnPaule
great plugin, thank you very much.
But can you please edit the formate on §date.formatted
Not:
14:34:23 So-03-2018
But:
14:34:23 So 25-03-2018
The formatted variable is totally up to you. Go to the device config page and change the dateformat parameter like you want.
Your case would be:
HH:mm:ss dd DD-MM-YYYY
@saxnpaule
Thank you that do the trick
Would be nice if the user also has the weekday name as a separate attribute. It can be realized by the attributes ‘formatted’ and ‘dateformat’ but then ‘formatted’ is lost for the full date. Take also into account that the ‘weekday name’ has several formats (dd, ddd, dddd).
Yes that’s right. But you also could create multiple devices.
@saxnpaule Yes, that is right, but I would like to keep things simple and compact.
Another issue is, that a device with multiple attributes should have customizable labels for each attribute (e.g. see SunriseDevice. May be you can add this.
Providing the display weekname leads to far in my opinion. Because how should it be displayed? d dd ddd?
The datetime plugin wasn’t build for displaying things. It’s only for providing variables. For display purposes you should use a VariableDevice. In this case you could also format the weekday as you want.
version 0.1.2 released 2018-03-30
@saxnpaule said in New plugin [pimatic-datetime]:
The datetime plugin wasn’t build for displaying things.
What you realized is a device and for me devices were always for displaying in the past. I see no problem in displaying it. It has working xAttributes ‘hidden’ and ‘displaySparkline’, the only thing I see which is missing is the a ‘label’ property for each attribute.
As far as I can see, there is no possibility to define a label/acronym for a variable in a “normal” device. Its only possible in a generic VariableDevice. Or is there something I don’t have in mind @mwittig
version 0.2.0 released 2018-04-03
@SaxnPaule I have file a pull request with a few suggested changes to improve the code. The most important one for me was to get rid of the second timer. Attributes are now updated when the reload cycle is performed. I have also tried to reduce code duplication by using the @_createGetter helper. Please give it a try.
"It always takes longer than you expect, even when you take into account Hofstadter's Law.", Hofstadter's Law
Pull request was already merged. Nice improvement. Thank you.