@mwittig Since your plugin for the Amazon Dash Button is the more actively developed one, i would suggest to merge both.
What if we introduce another device type DashButtonsDevice which inherits from ButtonsDevice like in pimatic-dash-button? Then i would remove my plugin from github and npm and would consider it deprecated. You could even use the name if you want
-
Merge pimatic-dash-button and pimatic-amazing-dash-button
pimatic-hap - pimatic HomeKit bridge
pimatic-echo - Amazon echo integration
pimatic-dash-button - Amazon dash button support
pimatic-alarm - pimatic alarm system
Like my work? Then consider a donation
Follow me: https://twitter.com/michaelkotten -
@michbeck100 said in Merge pimatic-dash-button and pimatic-amazing-dash-button:
Since your plugin for the Amazon Dash Button is the more actively developed one, i would suggest to merge both.
Makes sense to me.
My suggestion is to simply add the DashButtonDevice as another device type.
This way, use can decide if they want to use the button device or the contact sensor."It always takes longer than you expect, even when you take into account Hofstadter's Law.", Hofstadter's Law
-
@mwittig Perfect. I will try to create a PR this weekend if i find the time.
pimatic-hap - pimatic HomeKit bridge
pimatic-echo - Amazon echo integration
pimatic-dash-button - Amazon dash button support
pimatic-alarm - pimatic alarm system
Like my work? Then consider a donation
Follow me: https://twitter.com/michaelkotten -
@michbeck100 Sounds great!
"It always takes longer than you expect, even when you take into account Hofstadter's Law.", Hofstadter's Law
-
@mwittig See https://github.com/mwittig/pimatic-amazing-dash-button/pull/13. The weekend was a little bit longer than expected
pimatic-hap - pimatic HomeKit bridge
pimatic-echo - Amazon echo integration
pimatic-dash-button - Amazon dash button support
pimatic-alarm - pimatic alarm system
Like my work? Then consider a donation
Follow me: https://twitter.com/michaelkotten -
Any news with the pull request?
pimatic + MySensors + Homeduino + z-way
https://github.com/n3roGit/MySensors_n3ro