Pimatic & Node 8.0

---

@mwittig
I tried your solution, but it doesn´t work. I don´t know why. Maybe it is my fault.

@Jos-Hendriks
I will try your solution the next days. Thanks to you for your docker image. Pimatic works on my pi as a docker. I have now my own image, where everything is fine until the time zone.

Are there any plans to migrate pimatic to node js 6.11 LTE or even version 8?

well, we need to do something … yes!
but what the best solution will be is still to be discussed.
maybe @mwittig or @sweetpi is able to tell more

Any news guys?

@dk00000 said in Pimatic & Node 8.0:

Any news guys?

No. Everyone is very busy these days. I am shooting for Xmas holidays

@jos-hendriks said in Pimatic & Node 8.0:

Back on-topic: I think we have to plan for an upgrade to node js version 8. As of April 2018 maintenance on 4.x ends: https://github.com/nodejs/LTS#lts-schedule1

Is this critical?
hope that my pimatic works well also after april 2018 🙂

@dk00000 said in Pimatic & Node 8.0:

Is this critical?
hope that my pimatic works well also after april 2018

Yes. Certainly your stuff will also work after April 2018, however, using unsupported software is a risk.
The dependency on 4.x already is blocking issue as some libraries used for plugins have dropped 4.x support.

@mwittig did a short test with node v6 and v8 today. I found some glitches, had to update some dependencies but overall it doesn’t look too bad. Could you explain, what the biggest problems are?

BTW: if anyone wants to try: https://github.com/michbeck100/pimatic/tree/node_v8

I didn’t do any bigger testing, so be prepared that not everything will be working. Just make sure to do a clean install of pimatic.

@michbeck100 I just noticed you upgraded coffeescript to 2.2.1.

I am surprised you were able to compile the code because for example this:

class ErrorDevice extends Device
  constructor: (@config, @error) ->
    @name = @config.name
    @id = @config.id
    super()

Should throw a coffee compile error because you can’t use this/@ on derived classes without first calling super()

See http://coffeescript.org/v2/#breaking-changes-super-this

@amit-patel you are right. I had to make this change to my own plugin pimatic-echo . Maybe this just breaks if the code gets actually executed? And if you don’t use the ErrorDevice the code is never reached.

@michbeck100
FYI, I was just using ErrorDevice as a sample because it’s the first instance of in the devices file. There are dozens more just in that file. I mean, almost every device class uses that pattern.

I don’t think it matters if it’s executed or not. Its a compile error, not a runtime error. I just tested this by popping the above into a file, and compiling using CS2, and sure enough, it fails:

$ ./node_modules/coffeescript/bin/coffee -cb test.coffee
$/test.coffee:3:5: error: Can't reference 'this' before calling super in derived class constructors
   @name = @config.name

It makes me think that it’s not actually using locally installed lib.

@amit-patel THX for your finding! I fixed this now. The compiler says it’s ok .

@michbeck100 btw, did you see this pull request I made in the core lib: https://github.com/pimatic/pimatic/issues/1084 ?

It’s a pretty simple fix, if you wanted to implement in your fork.

@michbeck100 BTW, you’re still referencing this before calling super()

Using this one as an example:

 class LogActionProvider extends ActionProvider
      constructor: (@framework) ->
        super()

should be rewritten as

 class LogActionProvider extends ActionProvider
      constructor: (framework) ->
        super()
        @framework = framework

Another approach would be to change the base ActionProvider class to

  class ActionProvider
    constructor: (@framework) ->

    parseAction: (input, context) =>
      throw new Error("Your ActionProvider must implement parseAction")

and then in all the extended classes you can just use:

 class LogActionProvider extends ActionProvider
      constructor: (framework) ->
        super(framework)

@amit-patel Sorry but this is fine. See the link in your own comment: http://coffeescript.org/v2/#breaking-changes-super-this

    class B extends A
      constructor: (@arg) ->
        super(@arg)  # Throws a compiler error

but if you don’t pass this as parameter to the super class, its ok. So:

    class B extends A
      constructor: (@arg) ->
        super()  # compiles
        @arg.foo()

As I said, i compiled the whole project with the new coffeescript version

node_modules/coffeescript/bin/coffee -c .

I stand corrected. Apologies.

@amit-patel Nevermind! Thanks for your findings.

Hi there,

what is the status of Node 8.0 release. Is there made any progress?

If u need someone to test it, please let me know.

Greetings,
Ivan.

@michbeck100 said in Pimatic & Node 8.0:

@mwittig did a short test with node v6 and v8 today. I found some glitches, had to update some dependencies but overall it doesn’t look too bad. Could you explain, what the biggest problems are?

BTW: if anyone wants to try: https://github.com/michbeck100/pimatic/tree/node_v8

I didn’t do any bigger testing, so be prepared that not everything will be working. Just make sure to do a clean install of pimatic.

As I wrote earlier there is a branch you can use for testing

Node.js 10.x with long therm support has been released (https://medium.com/@nodejs/the-node-js-project-introduces-latest-release-line-node-js-10-x-bf07abfa9076)

Would it not make more sense to aim for the latest version instead?

Did anyone try to run pimatic with node v10 yet?