Pimatic & Node 8.0

---

@michbeck100 is this the right branch to use? https://github.com/michbeck100/pimatic/tree/0.9.44

@saxnpaule No, its https://github.com/michbeck100/pimatic/tree/node_v8

After installing sqlite manually I got your branch running with node 8.14.1.

During start, there is one compile error thrown during compilation of the cron plugin:

Can't reference 'this' before calling super in derived class constructors

Thats also the only error that occurs when I tried my water-level plugin.
After changing the position of super() calls to the beginning of the constructors the plugin compiles but is not usable.

As far as I understand it’s a difference between CoffeeScript 1 and 2.
Do you have a solution for this?

https://stackoverflow.com/questions/31067368/how-to-extend-a-class-without-having-to-using-super-in-es6

@saxnpaule just a wild guess, but do you see an assertion error like “the device has no id”?

Yes, exactly.

@saxnpaule thought so. Simple fix. I will post how to later today. Must sleep now.

@amit-patel awake again? Would be very cool if you could provide a solution. Then I could change most of my plugins during the next days.

@saxnpaule the problem is in the pimatic code. I did change some parts already but it’s not working yet. I hope i find the time tonight. Then I’ll try to post some instructions on what’s needed to do for node 8

Great, nice to hear.

@amit-patel said in Pimatic & Node 8.0:

the device has no id

This error is gone. Just pull the latest changes of the node_v8 branch. Happy testing!

I cloned the branch new and ran a “npm install” in pimatic directory. Unfortunately nothing changed:

@saxnpaule now comes the part where plugin developers have to update their software. Have a look a my commit for the dummy devices in pimatic core: https://github.com/michbeck100/pimatic/commit/844bf87f6fffe7556684c68b1366459b5862db84

Hope it gets clear then.

As I wrote here, this branch is for developers who are willing to update their plugins for node 8. I won’t (and can’t) give support for every error on the plugins users are using.
As far as I can tell the pimatic core seems to be kind of stable.

Yes I totally understand. Did you try your plugins with your pimatic branch?
Is your tradfri node_v8 branch working?

If I change the constructor it doesn’t work.

    constructor: (@config, @plugin) ->
      super(@config.id, @config.name)
      @uuid = @config.uuid
      @showGraph = @config.showGraph or true
      @graphDays = @config.graphDays or 7

It gives me:

[pimatic] Can't call super with @params in derived class constructors

I understand this, because there is no instantiation before the super call. So the @ couldn’t be used. But without @ I get a “config not found” exception.

@saxnpaule look at this commit: https://github.com/michbeck100/pimatic/commit/3e72a76835f9af2ec77222c994e5ffc93b84806e

Should be clear afterwards.
Apart from this refer to breaking changes of coffeescript 2: https://coffeescript.org/

I had a look into this commit. But there is no config to call super() with. This only works in your case because the config is defined in the Device class itself.

Because of that I asked whether your tradfri node_v8 branch is working.

Edit: Ah, it’s another commit. I need to check this.

That works for me. My plugin is working now. These small adjustments could easily be made to all of my plugins.

We need to define how to move forward. Should we define a peer dependency to pimatic 0.10.* or do you think we should do the step and use a major release? @mwittig What do you think?

@michbeck100 Dependent on @mwittig answer, could you change the version in your node_v8 branch?

@saxnpaule that change is already in my local checkout. I would say we use 0.10.x and the plugins must use this version as peer dependency. But I’m not sure if peer dependencies even work anymore with the npm bundled with node 8

There seems to be still an issue in pimatic. It’s not possible to add a rule.
When you type something in the “then” input field an error occurs:

13:53:44.473 [pimatic] Cannot read property 'ignoreCase' of null

@saxnpaule Good catch. This is because of different behavior in CoffeeScript 2 (see here). Should be fixed now. Just pull the latest changes.