[solved] pimatic-phone - presence sensor not updated by rule

---

Hi there,

I have been starting to use pimatic-phone (in combination with tasker on my Android device), which works pretty good.
However, I also have a dummy presence sensor:

    {
      "class": "DummyPresenceSensor",
      "id": "phone-lex2",
      "name": "Lex thuis",
      "autoReset": false
    }

and some rules:

when $galexy.location gets updated and $galexy.tag = "Home"
then set presence of phone-lex2 present
and push title:"Locatie Lex" message:"$galexy.tag" priority:0

when $galexy.location gets updated and $galexy.tag != "Home"
then set presence of phone-lex2 absent
and push title:"Locatie Lex" message:"$galexy.tag" priority:0

But these rules don’t work and I don’t know why…

Anyone got a clue why the presence sensor won’t update? I keeps the same state, wherever I am.

seems like $galexy.location is not updated automatically, so I changed it to $galexy.tag and now it is working

@lxz I think it is a flaw in the current implementation. Normally, each attribute value is held by an instance variable, e.g. “_tag” for the “tag” attribute value. However, this is not the case for “location” as this attribute simply is an alias for “tag”, i.e., getLocation() provides the “_tag” value.

The problem is the update handler for attribute values which only triggers update events for attributes which have an “_<attribute>” instance variable - which is not the case for location, position, previousLocation, and previousPosition. To mitigate the problem the _emitUpdates() needs to be partially rewritten, or the alias attributes need to removed.

https://github.com/bstrebel/pimatic-phone/issues/3

@lxz Thanks for debugging and the error report. The bug should be fixed with the just published v0.9.6 of pimatic-phone. Pls. let me know wheather everything works as expected and an can close issue #3

@mwittig Many thanks for reviewing and pointing out this issue.

I would like to keep the aliases for convenience in rule specification and changed the update handler to emit values for the alias attributes.

Hi there, thanks both of you for taking a look.
It looks like your changes fixed the issue.

Thanks a lot!

@lxz You are welcome.