ShellSensor running linux command with pimatic variable

---

Hi,
Currently I have a problem.

I have a couple of ESP Easy nodemcus running. They can send their uptime to pimatic and the EspEasy do that in minutes. So I have a variable:

    {
      "name": "cv-control-uptime",
      "value": 7601
    },

So if I do on the linux command line something like:

up=7601
printf '%d days %02d hours %02d minutes' $((up/1440)) $((up%1440/60)) $((up%60))
5 days 06 hours 41 minutes

So based on my variable I created a device:

    {
      "id": "cv-control-uptime",
      "name": "cv-control-uptime",
      "class": "ShellSensor",
      "attributeName": "time",
      "attributeType": "string",
      "attributeAcronym": "uptime cv-control",
      "command": "printf '%d days %02d hours %02d minutes' $((cv-control-uptime/1440)) $((cv-control-uptime%1440/60)) (($cv-control-uptime%60))",
      "interval": 60000
    }

I can’t get this work. No matter which quotes, backslashes and so forth I use. I always get 0 days 00 hours 00 minutes.

So I tried a second solution (actually because I can’t get this to work): I created a second variable like cvcontroluptcalc and change the command in my ShellSensor to
`“command”: "/home/harryvanderwolf/pimatic/scripts/esp-uptime.sh cvcontroluptcalc cv-control-uptime"
and write that script esp-uptime.sh like

#!/bin/bash

VARNAME=$1  # Variable to post back
UPTIME=$2 # value (=calculated) to post back

CALCULATED=$(printf '%d days %02d hours %02d minutes' $((UPTIME/1440)) $((UPTIME%1440/60)) $((UPTIME%60)))

curl -s -X PATCH --header "Content-Type:application/json" --data '{"type": "value", "valueOrExpression": "'$CALCULATED'"}' --user "$USERNAME:$PASSWORD" http://localhost/api/variables/$VARNAME > /dev/null

When I run that script from the command line or from my shellsensor I get:
error [pimatic]: Error on incoming http request to /api/variables/cvcontroluptcalc: Unexpected end of input

This script is a 100% copy of another “calculate time” script apart from the fact that the calculation is different. If I add an echo $CALCULATED the uptime is nicely echoed. The other script works fine.
I really don’t understand.

Hi Harry, regarding ShellSensor: https://github.com/pimatic/pimatic/issues/980

In theory you should be able to use a Variable with a expression like this:

"{round(($test/1440),0)} days {round((($test - (round(($test/1440),0)*1440))/60),0)} hours {$test - (round(($test/60),0)*60)} minutes"

Outputs:

5 days 7 hours -19 minutes

-19 as round rounds up from 126.6 minutes in the calculation.

I use round() + multiplications/division to “emulate” modulo and parse the time but it doesn’t work because we would need floor() instead of round(). However it should be quite easy to add some more functions there ideally allow the modulo operator.

https://github.com/pimatic/pimatic/blob/master/lib/variables.coffee#L219

There also seems to be a function to parse time already but it doesn’t cover days.

@thex said in ShellSensor running linux command with pimatic variable:

In theory you should be able to use a Variable with a expression like this:

What do you mean with this? I just tried it but it doesn’t work for me. Is that what you mean with: “in theory”?

@thex said in ShellSensor running linux command with pimatic variable:

https://github.com/pimatic/pimatic/blob/master/lib/variables.coffee#L219

There also seems to be a function to parse time already but it doesn’t cover days.

And how do I use that timeformat function? I tried already with timeFormat(cv-control-uptime) in a variable and a device, but it does nothing (unless I do it wrong)

In theory means that it doesn’t work correct because of the rounding problem described.
It should display the output I posted if the uptime in minutes is in the $test variable.

For the second point. As I said this can’t handle days yet end expects the input in seconds.

"timeFormat(($test * 60))"

Should at least calculate correct hours/minutes of your uptime

@thex said in ShellSensor running linux command with pimatic variable:

there ideally allow the modulo operator

I think you can use the % operator (modulo) as part of calculations, but haven’t tested it yet.

Thought so too but didn’t work for me

@mwittig
https://github.com/pimatic/pimatic/blob/26b81a38e477a9ef32cc985a8d1452b014cac099/lib/matcher.coffee#L392

I guess we would only need to add % here ore is it used for something else within pimatic as the matcher is used everywhere?

@thex said in ShellSensor running linux command with pimatic variable:

For the second point. As I said this can’t handle days yet end expects the input in seconds.

"timeFormat(($test * 60))"

Should at least calculate correct hours/minutes of your uptime

I currently have 1122 minutes which is 18 hours 42 minutes.
When I use that timeFormat($cv-control-uptime * 60) I do get 67320:00:00 which is ridiculous.

If I look at the function

        args:
          number:
            type: "number"
        exec: (number) ->
          hours = parseInt(number)
          decimalMinutes = (number-hours) * 60
          minutes = Math.floor(decimalMinutes)
          seconds = Math.round((decimalMinutes % 1) * 60)

So it expects hours meaning I need to do:
timeFormat($cv-control-uptime / 60) which indeed delivers me (now): 18:49:00

Oh sorry, it expects it as decimal hours so timeFormat(($test / 60)) should be right but it doesn’t really help you as it doesn’t currently support days

If you want to displays days as well you need something like:

        args:
          number:
            type: "number"
        exec: (number) ->
           days = parseInt(number/24)
           hours = parseInt(number - (days*24))
           minutes = parseInt(number -((days*24)+hours))

and perhaps display it as 2d 12:13:14 or something else “nice”

And coming back to the other part of the question with the script:

#!/bin/bash

VARNAME=$1  # Variable to post back
UPTIME=$2 # value (=calculated) to post back

CALCULATED=$(printf '%d days %02d hours %02d minutes' $((UPTIME/1440)) $((UPTIME%1440/60)) $((UPTIME%60)))

curl -s -X PATCH --header "Content-Type:application/json" --data '{"type": "value", "valueOrExpression": "'$CALCULATED'"}' --user "$USERNAME:$PASSWORD" http://localhost/api/variables/$VARNAME > /dev/null

When I run that script from the command line or from my shellsensor I get:
error [pimatic]: Error on incoming http request to /api/variables/cvcontroluptcalc: Unexpected end of input

This script is a 100% copy of another “calculate time” script apart from the fact that the calculation is different. If I add an echo $CALCULATED the uptime is nicely echoed. The other script works fine.

Somehow the $CALCULATED is “wrong” but I have no idea why.
Anyone?

I now know why the error occurs: Due to the spaces!

I send something like 7 days 23 hours 40 minutes in the variable. Then I get the error [pimatic]: Error on incoming http request to /api/variables/cvcontroluptcalc: Unexpected end of input.

This makes a lot of sense as you have to urlencode such a spaces containing string so I tried:
curl -s -X PATCH --header "Content-Type:application/json" --data-urlencode '{"type": "value", "valueOrExpression": "'$CALCULATED'"}' --user "$USERNAME:$PASSWORD" http://localhost/api/variables/$VARNAME > /dev/null
Note the --data-urlencode instead of --data.

Now the http request does not fail but pimatic barfs on the string as it encounters a % sign.
error [pimatic]: Error on incoming http request to /api/variables/cvcontroluptcalc: Unexpected token %

This becomes a vicious circle.

@Harry-van-der-Wolf I am confused. Isn’t the patch data sent as an Json object in the request body? So, why should this be URL-encoded. I think you need to further escape quotes to get it right.

@Harry-van-der-Wolf The following should work:

curl -s -X PATCH --header "Content-Type:application/json" --data '{"type": "value", "valueOrExpression": "'"$CALCULATED"'"}' --user "$USERNAME:$PASSWORD" http://localhost/api/variables/$VARNAME > /dev/null

Here is my test run for setting a variable ‘xy’:

pi@raspi3:~ $ CALCULATED="7 days 23 hours 40 minutes"
pi@raspi3:~ $ VARNAME=xy
pi@raspi3:~ $ curl -XPATCH --header "Content-Type:application/json" --data '{"type": "value", "valueOrExpression": "'"$CALCULATED"'"}' --user "$USERNAME:$PASSWORD" http://localhost/api/variables/$VARNAME
{"variable":{"name":"xy","readonly":false,"type":"value","value":"7 days 23 hours 40 minutes","unit":""},"success":true}

Thank you.
I had already tried the same but as "'\"$CALCULATED\"'" as I thought I had to escape the second ".

Your version works indeed.