pimatic-hap / pimatic-wink - Homekit on/off for dimmers

---

Again I am not sure if this is a pimatic-hap issue or pimatic-wink issue but I thought DimmerAccutator has seperate functions for on/off and dimming. I was using openhab earlier and there I could turn a switch on/off without affecting the dim level. However whenever I use a homekit app to turn off/on the dim levels move to 100%/0%,

They are really two independent functions, at-least for wink, both wink app and api allow for turning on and off without changing dim levels - is this a pimatic limitation because the pimatic UI doesn’t have independant on/off for dimmers or is this a pimatic-wink implementation issue?

In the toggle dimmer thread https://forum.pimatic.org/topic/1419/toggle-dimmers/5 there is mention of HomeduinoRFDimmer perhaps supportiong this. However unlike that plugin, wink plugin shouldn’t have to remember the level becuae Wink does that for us.

CC: @michbeck100 @dgmltn

@Enis-Hoca the implementation of the dimmer in pimatic actually has a method for switching on and off. But by default this just sets the dim level to 0 or 100. pimatic-hap implements the same behavior. Before changing this in pimatic-hap it should be changed in pimatic itself. Otherwise the internal states would differ between HomeKit and pimatic.

@michbeck100
Could you please check for a solution with @sweetpi and @mwittig ?

@michbeck100 I think you should not translate the device state on to dimmer percent. Since you are just a bridge you should just pass it through and let the underlying plugin or pimatic default do its job. I made the following change in dimmer.coffee constructor and - everything continues to work as expected, pimatic stays consistent. The base class for DimmerAcutator is switch anyway, so if a plugin wants to do that translation fine, but there is no reason to force it.

  ##device.on 'dimlevel', (dimlevel) =>
       ##@getService(Service.Lightbulb)
      ##.setCharacteristic(Characteristic.Brightness, dimlevel)

  device.on 'state', (state) =>
    @getService(Service.Lightbulb)
      .setCharacteristic(Characteristic.On, state)

@Enis-Hoca The listener for ‘state’ is already implemented in the base class SwitchAccessory. So you’d recommend to remove the dim level listener, right?
That would mean that HomeKit doesn’t get an update when the dim level is changed on the pimatic side. I don’t see how this can be consistent.
The homekit bridge is meant to implement a two-way communication. If the user changes values on the homekit side, it will be populated to pimatic and vice versa.

@michbeck100 you are right about that - however if this is to be two way then how about handling the state too in addition to dim level - that would ensure that if only state is change is to be passed it can flow through regardless of the dim level

@Enis-Hoca Again, the listener for ‘state’ is already implemented in the base class SwitchAccessory:

dimmer.coffee:12

class DimmerAccessory extends SwitchAccessory

switch.coffee:37

device.on 'state', (state) =>
        @getService(service)
          .setCharacteristic(Characteristic.On, state)

And please remember, when Pimatic switches the state of a dimmer to on or off, it just sets the dim level to 0 or 100. See devices.coffee in pimatic/lib line 343.