Errors with pimatic-hap and pimatic-wink

---

Hi -
I am getting errors coming from pimatic-hap when it runs with pimatic-wink, not sure whether the errors are because something is missing in one of the plugins. Its my first day with pimatic and am still figuring it out. any help is would be appreciated. thanks

I get this error whenever I change anything on a device from a HK app :

[pimatic-hap] Could not call promise: Cannot call method ‘then’ of undefined

During startup I get these errors:
Unhandled rejection TypeError: Cannot call method ‘then’ of undefined
at DimmerAccessory.BaseAccessory.handleVoidPromise (/media/untitled/pimatic-app/node_modules/pimatic-hap/accessories/base.coffee:44:10)
at DimmerAccessory.handleVoidPromise (/media/untitled/pimatic-app/node_modules/pimatic-hap/accessories/base.coffee:1:1)
at [object Object].<anonymous> (/media/untitled/pimatic-app/node_modules/pimatic-hap/accessories/dimmer.coffee:40:12)
at [object Object].EventEmitter.emit (events.js:106:17)
at [object Object].Characteristic.setValue (/media/untitled/pimatic-app/node_modules/pimatic-hap/node_modules/hap-nodejs/lib/Characteristic.js:155:10)
at [object Object].Service.setCharacteristic (/media/untitled/pimatic-app/node_modules/pimatic-hap/node_modules/hap-nodejs/lib/Service.js:147:32)
at WinkLightBulb.<anonymous> (/media/untitled/pimatic-app/node_modules/pimatic-hap/accessories/dimmer.coffee:27:12)
at WinkLightBulb.EventEmitter.emit (events.js:117:20)
at WinkLightBulb.DimmerActuator._setDimlevel (/media/untitled/pimatic-app/node_modules/pimatic/lib/devices.coffee:313:8)
at WinkLightBulb._setDimlevel (/media/untitled/pimatic-app/node_modules/pimatic/lib/devices.coffee:1:1)
at /media/untitled/pimatic-app/node_modules/pimatic-wink/pimatic-wink.coffee:129:29
at tryCatcher (/media/untitled/pimatic-app/node_modules/pimatic/node_modules/bluebird/js/main/util.js:26:23)
at Promise._settlePromiseFromHandler (/media/untitled/pimatic-app/node_modules/pimatic/node_modules/bluebird/js/main/promise.js:507:31)
at Promise._settlePromiseAt (/media/untitled/pimatic-app/node_modules/pimatic/node_modules/bluebird/js/main/promise.js:581:18)
at Async._drainQueue (/media/untitled/pimatic-app/node_modules/pimatic/node_modules/bluebird/js/main/async.js:128:12)
at Async._drainQueues (/media/untitled/pimatic-app/node_modules/pimatic/node_modules/bluebird/js/main/async.js:133:10)
at Async.drainQueues (/media/untitled/pimatic-app/node_modules/pimatic/node_modules/bluebird/js/main/async.js:15:14)
at process._tickCallback (node.js:415:13)
Unhandled rejection TypeError: Cannot call method ‘then’ of undefined
at DimmerAccessory.BaseAccessory.handleVoidPromise (/media/untitled/pimatic-app/node_modules/pimatic-hap/accessories/base.coffee:44:10)
at DimmerAccessory.handleVoidPromise (/media/untitled/pimatic-app/node_modules/pimatic-hap/accessories/base.coffee:1:1)
at [object Object].<anonymous> (/media/untitled/pimatic-app/node_modules/pimatic-hap/accessories/dimmer.coffee:40:12)
at [object Object].EventEmitter.emit (events.js:106:17)
at [object Object].Characteristic.setValue (/media/untitled/pimatic-app/node_modules/pimatic-hap/node_modules/hap-nodejs/lib/Characteristic.js:155:10)
at [object Object].Service.setCharacteristic (/media/untitled/pimatic-app/node_modules/pimatic-hap/node_modules/hap-nodejs/lib/Service.js:147:32)
at WinkLightBulb.<anonymous> (/media/untitled/pimatic-app/node_modules/pimatic-hap/accessories/dimmer.coffee:27:12)
at WinkLightBulb.EventEmitter.emit (events.js:117:20)
at WinkLightBulb.DimmerActuator._setDimlevel (/media/untitled/pimatic-app/node_modules/pimatic/lib/devices.coffee:313:8)
at WinkLightBulb._setDimlevel (/media/untitled/pimatic-app/node_modules/pimatic/lib/devices.coffee:1:1)
at /media/untitled/pimatic-app/node_modules/pimatic-wink/pimatic-wink.coffee:129:29
at tryCatcher (/media/untitled/pimatic-app/node_modules/pimatic/node_modules/bluebird/js/main/util.js:26:23)
at Promise._settlePromiseFromHandler (/media/untitled/pimatic-app/node_modules/pimatic/node_modules/bluebird/js/main/promise.js:507:31)
at Promise._settlePromiseAt (/media/untitled/pimatic-app/node_modules/pimatic/node_modules/bluebird/js/main/promise.js:581:18)
at Async._drainQueue (/media/untitled/pimatic-app/node_modules/pimatic/node_modules/bluebird/js/main/async.js:128:12)
at Async._drainQueues (/media/untitled/pimatic-app/node_modules/pimatic/node_modules/bluebird/js/main/async.js:133:10)
at Async.drainQueues (/media/untitled/pimatic-app/node_modules/pimatic/node_modules/bluebird/js/main/async.js:15:14)
at process._tickCallback (node.js:415:13)

my config
"devices": [
{
“id”: “my-light-bulb”,
“class”: “WinkLightBulb”,
“name”: “Bedroom Lamp”,
“hap”: {
“service”: “Lightbulb”,
“exclude”: false
}
},
{
“id”: “my-fan”,
“class”: “WinkLightBulb”,
“name”: “Bedroom Fan”,
“hap”: {
“service”: “Fan”,
“exclude”: false
}
},
{
“id”: “my-ac”,
“class”: “WinkBinarySwitch”,
“name”: “Bedroom AC”,
“hap”: {
“service”: “Switch”,
“exclude”: false
}
}
],

CC: @michbeck100 @dgmltn

@Enis-Hoca @dgmltn there is a bug in the pimatic-wink library. The overridden method changeDimlevelTo is supposed to return a promise which it doesn’t. I just calls _setDimlevel(…), but this method doesn’t return a promise.

@michbeck100 thanks for looking into it - can you advise on how i can add this?

In WinkLightBulb.prototype.changeDimlevelTo

I changed

  if (this._dimlevel === dimlevel) {
    return;
  }

to
if (this._dimlevel === dimlevel) {
return Promise.resolve();
}

that made the error go away - not sure if thats the right thing to do or not.

@Enis-Hoca This looks good. My first guess was wrong.

  return wink_device_id_map()
    .then( (result) => wink_light_bulb(result[@name].device_id, dimlevel) )
    .then( (result) => @_setDimlevel(dimlevel) )

does return a promise. I didn’t see the line before:

  if @_dimlevel is dimlevel then return

This doesn’t return a promise. So your fix is correct.

For info, I have created a PR to fix this issue and to ensure compatibility with the upcoming pimatic 0.9 release.
https://github.com/dgmltn/pimatic-wink/pull/2

thanks for doing that.