Problem with the shell-sensor and a bash script

---

Hello again,

I want to see in the GIU, if anyone phoned. So I have a bash that returns 0 if nobody phoned or anything greater 0 if the phone is used.

I try this:

{
 "id": "phone-signal",
 "class": "DummyPresenceSensor",
 "name": "Telefonie aktiv",
 "autoReset": false
},
{
 "id": "phone-detect",
 "name": "Telefonie",
 "class": "ShellSensor",
 "attributeName": "phonedetect",
 "attributeType": "number",
 "attributeUnit": "",
 "command": "bash /usr/local/pimatic-app/phonedetect.sh",
 "interval": 60000
}

to switch the DummyPresenceSensor I use these two rules

{
  "id": "telefonieanzeige-ein",
  "name": "Telefonieanzeige ein",
  "rule": "if $phone-detect.phonedetect > 0 then set presence of phone-signal present",
  "active": true,
  "logging": true
},
{
  "id": "telefonieanzeige-aus",
  "name": "Telefonieanzeige aus",
  "rule": "if $phone-detect.phonedetect = 0 then set presence of phone-signal absent",
  "active": true,
  "logging": true
}

but the value of $phone-detect.phonedetect was null and in the logfile is this result:

Unhandled rejection Error: Command failed:
at ChildProcess.exithandler (child_process.js:637:15)
at ChildProcess.EventEmitter.emit (events.js:98:17)
at maybeClose (child_process.js:735:16)
at Process.ChildProcess._handle.onexit (child_process.js:802:5)

What is wrong?

@HermannDerUser Can you please also post the shell script /usr/local/pimatic-app/phonedetect.sh? Apart from this, I am wondering why you haven’t used the ShellPresenceSensor - see https://github.com/pimatic/pimatic-shell-execute#shellpresencesensor-device

@mwittig

here is the bash

#!/bin/bash

_BOXURL=“http://fritz.box”
_USERNAME=“user”
_PASSWORD=“passwort”
_REQUESTPAGE="/system/update.lua?check=1"

_CHALLENGE=$(curl -s ${_BOXURL}/login.lua | grep “^g_challenge” | awk -F ‘"’ ‘{ print $2 }’)
_MD5=$(echo -n ${_CHALLENGE}"-"${_PASSWORD} | iconv -f ISO8859-1 -t UTF-16LE | md5sum -b | awk ‘{print substr($0,1,32)}’)
_RESPONSE="${_CHALLENGE}-${_MD5}"
_SID=$(curl -i -s -k -d ‘response=’${_RESPONSE} -d ‘page=’ -d “username=${_USERNAME}” “${_BOXURL}/login.lua” | grep “Location:” | grep -Poi ‘sid=[a-f\d]+’ | cut -d ‘=’ -f2)
curl -s “${_BOXURL}${_REQUESTPAGE}” -d “sid=${_SID}” | grep -E -i -c “Es wird zur Zeit noch telefoniert.”

I found the combination of DummyPresenceSensor and ShellSensor here in another posting. I did not know the shellpresencesensor-device and will look at it to me.

I have tried the shellpresencesensor-device

{
  "id": "phone-signal",
  "class": "ShellPresenceSensor",
  "name": "Telefonie aktiv",
  "command": "bash /usr/local/pimatic-app/phonedetect.sh",
  "interval": 60000,
  "autoReset": false,
  "resetTime": 10000
},

but there is also an error:

Unhandled rejection Error: Command failed:
at ChildProcess.exithandler (child_process.js:637:15)
at ChildProcess.EventEmitter.emit (events.js:98:17)
at maybeClose (child_process.js:735:16)
at Socket.<anonymous> (child_process.js:948:11)
at Socket.EventEmitter.emit (events.js:95:17)
at Pipe.close (net.js:466:12)

also expects the device a result of 0 or 1. In my case but it is ‘0’ or ‘> 0’

    description: "
      the command to execute to get the presence state.
      Can return on/off, true/false or 1/0 as string
    "

On the shell my bash works well.

maybe it is helps when you should add echo"text"

curl -s "${_BOXURL}${_REQUESTPAGE}" -d "sid=${_SID}" | grep -E -i -c echo"Es wird zur Zeit noch telefoniert."

@HermannDerUser The script partly works for me if a call is in progress. However, if the no call is in progress I am getting the exception, too. The problem is that the script terminates with execution result 1 (an execution state other than 0 means error). You can check the execution state right after the script excecution using echo $?. For example:

bash phonedetect.sh
echo $?
# This will prompt 1 if no call in progress

Actually, the error is caused by the grep command as grep terminate with status 1 if it did not match the pattern as described here http://www.gnu.org/software/grep/manual/html_node/Exit-Status.html Note, that using option -q does not help as this will only be quiet on errors (using status code 0 instead of 2). One way of fixing the prroblem is to pipe the output through some other command. I am using teehere and it works fine for me. This is the complete script which works for me:

#!/bin/bash

_BOXURL="http://fritz.box"
_USERNAME=""
_PASSWORD="xxxxxxx"
_REQUESTPAGE="/system/update.lua?check=1"

_CHALLENGE=$(curl -s ${_BOXURL}/login.lua | grep "^g_challenge" | awk -F '"' '{ print $2 }')
_MD5=$(echo -n ${_CHALLENGE}"-"${_PASSWORD} | iconv -f ISO8859-1 -t UTF-16LE | md5sum -b | awk '{print substr($0,1,32)}')
_RESPONSE="${_CHALLENGE}-${_MD5}"
_SID=$(curl -i -s -k -d 'response='${_RESPONSE} -d 'page=' -d "username=${_USERNAME}" "${_BOXURL}/login.lua" | grep "Location:" | grep -Poi 'sid=[a-f\d]+' | cut -d '=' -f2)
curl -s "${_BOXURL}${_REQUESTPAGE}" -d "sid=${_SID}" | grep -E -i -c "Es wird zur Zeit noch telefoniert." | tee

EDIT: Occasionally, I’ll improve error handling of the plugin to make it easier to find such errors

@p4co86

Thanks for the idea with echo. After I have tried a lot, I found the following solution the combination of DummyPresenceSensor and ShellSensor:

_RESULT=$(curl -s “${_BOXURL}${_REQUESTPAGE}” -d “sid=${_SID}” | grep -E -i -c “Es wird zur Zeit noch telefoniert.”)
echo “$_RESULT”

@mwittig
Ups… I’ve found my solution before, but I will also try your way after that.

@HermannDerUser said:

Ups… I’ve found my solution before, but I will also try your way after that.

Never mind. The result with the echo command is the same. Hope, the explanation on exit code makes sense to you.

Regarding your solution my suggestion is to use echo -n "$_RESULT" to avoid the extra newline. However, it should even work with the extra newline as the output will be trimmed anyway

EDIT: NB, I have filed a PR to improve error handling https://github.com/pimatic/pimatic-shell-execute/pulls

after updating shell, i get the following error:

ShellSwitch: Command execution failed with exit code undefined (undefined)

no idea ? ive tried fixing it myself, but could not find the issue.
Thanks in advance

i find out, that a shell switch gives me the issue, but in the command line i get the state

off and on, so it should not give me an error.

EDIT: ive seen that sometimes the command gives an empty string back, so this is the issue but how can i fix it. its not the prblem when it sometimes gives an empty string, but the error is anoying.

@p4co86 Do you also get an error message as follows:

ShellSwitch: stderr output from ...

@mwittig no