Cannot call method 'then' of undefined`

---

hi guys

i have a log problem with the following rule:

if $wohnzimmer.dimlevel changes then dim Sideboard to $wohnzimmer.dimlevel and after 1 seconds dim Ecke to $wohnzimmer.dimlevel and after 2 seconds dim Couch to $wohnzimmer.dimlevel

it works fine (everytime) but sometimes a get the following logmessage:

error [pimatic]: rule wohnzimmer error executing an action: Cannot call method 'then' of undefined`

any ideas?

is there nobody with the same problem or someone how had an idea whats wrong in this rule?
i do have a lot of rules with a lot of error messages day by day

Hey,

The rule name is this rule?

@dk00000 Works for me. I can’t reproduce the error so far. However, as I only have two dimmers I had to slightly modify the rule for my setup:

{
      "id": "dimlevel",
      "name": "dimlevel",
      "rule": "if $milightl.dimlevel changes then dim milight4 to $milightl.dimlevel and after 1 seconds dim milight4 to $milightl.dimlevel + 5 and after 2 seconds dim milight4 to $milightl.dimlevel + 10",
      "active": true,
      "logging": true
}

Questions:

• Are Sideboard, Ecke, and Couch, of the same device type? Which device types are involved?
• Which type of device is $wohnzimmer is referring to?
• Did you try to slice the rule into three rules? Do you get the same error and does it occur on all of the three rules?

@mwittig
sideboard, ecke and couch are z-way dimmer (“multilevelswitch” for roller shutter)

{
      "class": "ZWayDimmer",
      "id": "Ecke",
      "name": "Ecke",
      "virtualDeviceId": "ZWayVDev_zway_2-0-38",
      "interval": 10
    },

wohnzimmer is a dummydimmer which i use to dim this 3 devices with this rule (also called wohnzimmer).
i also have this kind of rules for other z-way dimmers with the same error

do you think the reason could be the z-way plugin?

I believe i can reproduce the error:

I have a buttonsdevice to control a dimmer to 30%. If the dimmer is already at 30% and i press the button then i get the error:

13:15:14error [pimatic]: Error on evaluation of rule condition of rule sonnetv: Cannot call method ‘then’ of undefined
13:15:14error [pimatic]: rule sonnetv error executing an action: Cannot call method ‘then’ of undefined

But why?
How can i avoid such error messages?

No ideas? Or am i the only one with such error messages?

@dk00000 Could you enable debug output and post the debug message here or open a issue on github?
https://github.com/pimatic/pimatic/issues/137

@sweetpi

this is the debug log:

19:55:59.081 [pimatic] debug: TypeError: Cannot call method 'then' of undefined
19:55:59.081 [pimatic] debug:>    at DimmerActionHandler._doExecuteAction (/home/pimatic-app/node_modules/pimatic/lib/actions.coffee:824:43)
19:55:59.081 [pimatic] debug:>    at DimmerActionHandler._doExecuteAction (/home/pimatic-app/node_modules/pimatic/lib/actions.coffee:1:1)
19:55:59.081 [pimatic] debug:>    at /home/pimatic-app/node_modules/pimatic/lib/actions.coffee:832:17
19:55:59.081 [pimatic] debug:>    at tryCatcher (/home/pimatic-app/node_modules/pimatic/node_modules/bluebird/js/main/util.js:24:31)
19:55:59.081 [pimatic] debug:>    at Promise._settlePromiseFromHandler (/home/pimatic-app/node_modules/pimatic/node_modules/bluebird/js/main/promise.js:466:31)
19:55:59.081 [pimatic] debug:>    at Promise._settlePromiseAt (/home/pimatic-app/node_modules/pimatic/node_modules/bluebird/js/main/promise.js:545:18)
19:55:59.081 [pimatic] debug:>    at Promise._settlePromises (/home/pimatic-app/node_modules/pimatic/node_modules/bluebird/js/main/promise.js:661:14)
19:55:59.081 [pimatic] debug:>    at Async._drainQueue (/home/pimatic-app/node_modules/pimatic/node_modules/bluebird/js/main/async.js:79:16)
19:55:59.081 [pimatic] debug:>    at Async._drainQueues (/home/pimatic-app/node_modules/pimatic/node_modules/bluebird/js/main/async.js:89:10)
19:55:59.081 [pimatic] debug:>    at Async.drainQueues (/home/pimatic-app/node_modules/pimatic/node_modules/bluebird/js/main/async.js:14:14)
19:55:59.081 [pimatic] debug:>    at process._tickCallback (node.js:415:13)

Thanks. It’s bug in the z-way plugin. I submitted a pull request: https://github.com/MMore/pimatic-z-way/pull/2/files

Thanks @sweetpi
I have updated the Z-way plugin.
I will give you my test results next days.

EDIT: oh… have not seen that the update doesnt include the fix
so i will wait for the next update.

I just released the bugfix, @dk00000. Thanks @sweetpi.

thanks to @MMore and @sweetpi for the bugfix.
first day without any error messages. yes!!!