[Solved]pimatic-openweather variable problem with pimatic-pushover

---

Hey fellas,
I have a strange behavior sending openweather variables via pimatic-pushover.

I know we could discuss about sense or nonsense of this, but I try to send a weather update from pimatic-openweather once a day over pimatic-pushover and the only value I get is ‘undefined’.

My rule looks as follows:
if it is 06:00
then push title:"Weatherinfo" message:"$forecast_today.status ($forecast_today.low to $forecast_today.high)" priority:1

Only message I get is
undefined (undefined to undefined)

With my temperature sensors (DS18B20 and DHT22) it’s working just fine. Only with the openweather data it screws it up.

What am I doing wrong?

Thanks,
fletcher

@fletcher @sweetpi

I think I am facing a similar problem. I am trying to read temperature and humidity from openweather using a “VariablesDevice”, but the variables do not appear to be updated with the actual openweather readings. If I use other variable expressions instead I get proper values.

Here is my setup

{
      "id": "vars1",
      "class": "VariablesDevice",
      "name": "VARS",
      "variables": [
        {
          "name": "temperature",
          "type": "string",
          "expression": "$weather.temperature",
          "unit": "°C"
        },
        {
          "name": "humidity",
          "type": "string",
          "expression": "$weather.humidity",
          "unit": "%"
        }
      ]
    },
    {
      "id": "weather",
      "class": "OpenWeatherDevice",
      "name": "Wetter",
      "location": "Schermer, Netherlands",
      "units": "metric",
      "lang": "de",
      "timeout": 200000
    },

Variables display contains the following:
$weather.humidity: 70%
$weather.temperature: 14.4°C
$vars.humidity: null%
$vars.temperature: null°C

The value getter looks wrong in the openweather device
https://github.com/josecastroleon/pimatic-openweather/blob/master/openweather.coffee#L119-L125
i think it should something like this.

getHumidity: -> Promise.resolve @humidity

@Icesory Thank you for your feedback which actually put me on the right track

The idea of the getTemperature: -> @_currentRequest.then(-> @temperature ) statement is to delay the result until the data has been read from the openweather service once. The problem is, however, that the inner -> is wrong. It needs to be replaced by => to bind the promise callback to the device instance. Another problem is, that the code does not assign the values to the attribute members as it only emits the event. The event trigger may also result in an attribute value update, however, this will happen too late for getters as the event listeners will be executed in the next cycle. Later today I’ll file a PR with a suggested fix.

@mwittig thanks for the pull request. Published a version with that fix.

Great! That worked for me as well. Thanks everybody!

Next beer is on me.