Nice plugin! There are a couple of issues I have.
- Plugin configuration options: Are these values really required? Looks like this is redundant as the
device configuration requires the same values for both device types - The update logic for the
WaterLevelSensordoes not seem to work properly -> value remains “null” initially eventhough the value is requested by the device implementation. Is seems like the attribute value is not updated in some cases. - The
WaterLevelDevicegets updated through the front end. In other words, it is the browser issuing the REST request. Is this done on purpose? What if no front-end is opened or multiple front-ends are opened. - The
WaterLevelDevicedoes not exhibit thelevelas an attribute. Why do I need theWaterLevelSensorfor this? It would would be nice to have just one device type! - Edit-link for
WaterLevelDeviceon items page is not supported. Would be nice to have this as it serves as shortcut to editing a device. - The
currentLeveldevice configuration item of aWaterLevelDeviceappears to be obsolete
!