Press MqttButton through rule: Cannot read property 'then' of undefined

---

I have created some MqttButtons. When pressed a message is published on a mqtt topic. Works fine. However, when this button is pressed through a rule a error is logged in the log:
error [pimatic]: rule anybody-home-tablet-on error executing an action: Cannot read property 'then' of undefined
The button is pushed and the message is published to mqtt but somehow it throws an error

Hey #metoo

Thanks. I will fix it in the next release.

I also get that error when I click on a device to edit but instead of clicking edit I clock somewhere in the black box.

This is in Chrome on Windows.

@developer @wutu Can please someone look into it? It’s really annoying.

I have had this error several times recently with the intergasincomfort plugin. with the set temp of thermostat to... action. I might have a look when I have some free time, unless someone already pinpointed the defect…

@dan i asked here because the developer @wutu is currently inactive. We have also raised an issue in his repo at github.

Need to analyze first, but my gut feel is this may be a defect in the ActionHandler or Device base classes if different specific implementations of these classes seem to experience the same issue. HeatingThermostat and ButtonsDevice are different implementations of the same parent class. My intergasincomfort and the mqtt inherit from these in turn.
Interestingly other implementations seem to be ok. If I am not mistaken, a commonality between the two plugins is network connectivity to other systems. This may be part of the circumstance triggering this error. Hurray! Nightmare to troubleshoot

Thanks for investigating it. Maybe @mwittig can help you?

@kenci said in Press MqttButton through rule: Cannot read property 'then' of undefined:

We have also raised an issue in his repo at github.

Which one? Can you please provide more details.
Who is “we” by the way?

“we”, the users

https://github.com/wutu/pimatic-mqtt/issues/30

@kenci Ok, thanks for the clarification

I had a look at the issue and I have filed a pull request with a candidate fix.
https://github.com/wutu/pimatic-mqtt/pull/37

For the books:
@developer please note, action operations must always return a Promise

@mwittig I’ll look at the intergas plugin, likely same cause then. Thanks for jumping in!

@mwittig @Dan thanks guys, i really appreciate it

Hi, fixed in ver. 0.9.10.

Thx @mwittig

@wutu,

I tried to upgrade MQTT plugin from 0.9.7 to 0.9.10. The pimatic plugin page is not supporting this, because the latest version on the plugin page is 0.9.7. So I did a manual update.
On my plugin page the MQTT plugin is now labelled “compatibility unknown”.
The plugin seems to work, but any idea if this is a problem?

@bertreb said in Press MqttButton through rule: Cannot read property 'then' of undefined:

The pimatic plugin page is not supporting this, because the latest version on the plugin page is 0.9.7. So I did a manual update.

Are you sure? On the web site it is showing the info for 0.9.10. So, the pimatic version manager should also pickup 0.9.10 via pimatic front end when searching for updates

https://pimatic.org/plugins/pimatic-mqtt/

You are right. Npm is showing the latest version. In my pimatic plugin page the version was 0.9.7 and no update for this plugin was available. So i installed the newest version manually and added the pimatic peerDependency in the plugins package.json (to remove the compatibilty label).

Hello, I am working with MQTT version 0.9.7 for 2 installations and no update is offered.
By, Jens.

@jens Ok, seems like I also install the stuff manually as part of my docker testing. The issue has been fixed now and the plugin manager should pick up an update to v0.9.11