@Fjux We should avoid doing the same thing twice. I have already started to some work on pimatic-iwy-light-master to integrate milight by using your fork of node-milight. May be you spend some time on fixing and improving node-milight?
-
Plugin for WIFI controlled LED light (IWY-Light)
"It always takes longer than you expect, even when you take into account Hofstadter's Law.", Hofstadter's Law
-
@philip1986 Can you please enable “Issues” on the github project, please? I think it is disabled because the project was a fork previously. You should be able to enable “Issues” by clicking on “Settings” on the right hand side of the github project page. Thanks!
"It always takes longer than you expect, even when you take into account Hofstadter's Law.", Hofstadter's Law
-
Issues are enabled now.
-
I changed the plugin name to pimatic-led-light and solved the npm install issue. It is now published under https://www.npmjs.com/package/pimatic-led-light.
@sweetpi can you please update this on the homepage as well.
-
Nice, homepage and plugin list updated.
-
@Fjux Ok I got your point and I agree this is the better solution.
Can you please create the PR agin against the branch ‘feature/support_mutiple_devices’ . I like to merge it, polish it up a bit to make it work for the current devices. And you can start to implement the wrapper class MilightLed.
-
@philip1986 and @Fjux: I have created a fork yesterday and published pull request today for the separation into multiple device types and the integration of Milight. See comments on https://github.com/philip1986/pimatic-led-light/issues/5
btw. Milight as part of pimatic-led-light basically works Just the recovery of the power state from DB does not work properly. Note, it is not possible to query the state from a Milight device (comms is one-way).
"It always takes longer than you expect, even when you take into account Hofstadter's Law.", Hofstadter's Law
-
Milight has some more functions which are probably not supported by IWY-Master and Wifi370. To give you an idea what it is, have look at the demo video of the openHAB Milight Binding.
"It always takes longer than you expect, even when you take into account Hofstadter's Law.", Hofstadter's Law
-
Some Mobile GUI Dimmer and Color Picker variations:
-
Will this color picker device be integrated in to pimatic? So i can call it in other plugins?
I can send rgb hex codes to my moodlight (mysensors).
For a dimmer i call env.devices.DimmerActuator, will this be possible for a color picker too?
-
I found some code with many more Wifi RGB versions! https://github.com/herrmannj/wifilight http://www.fhemwiki.de/wiki/WifiLight#on_.2F_off
The HX version of the WF200 (wifi370) controller is interesting, it’s a wifi370 clone and normally can only be controlled in it’s own wifi network. It’s called LW12HX in the code. I saw that @leader21 and @Icesory got these controllers, I got three of them.
Oh and maybe we can merge the two topics? This is a bit confusing :P.
-
closed the other threat http://forum.pimatic.org/topic/372/mi-light-iwy-ect-and-wifi-370-integration
let’s discuss things here.pimatic v0.9 has been released!
Support Pimatic and get some free stickers
Like us on Facebookmake it so !
-
@Fjux and @mwittig I managed to have a deeper look into your PRs and I created a new one based on your ideas. So please have a look into it and tell me what you think. https://github.com/philip1986/pimatic-led-light/pull/7
I also split the code into different files in oder to provide a better structure for implementing new devices. So sorry for potential merge conflicts.
@mwittig said:
Milight has some more functions which are probably not supported by IWY-Master and Wifi370. To give you an idea what it is, have look at the demo video of the openHAB Milight Binding.
Iwy has also some “bulid-in programs” and a music mode see here
https://www.youtube.com/watch?v=G0sGrnOunTE (from at 1:55)I considered those features as less important for a first implementation, but we can defiantly thing about how we can implement those features into pimatic.
There are also LED which doesn’t have a color mode, just withe white with dimming functionality, or others which only run in color mode. We should thing how to deal with devices that provide not all features we support and disable/hide UI elements in those cases. -
@philip1986 OK thanks, I’ll have a look
There are also LED which doesn’t have a color mode, just withe white with dimming functionality
Same with Milight btw. and there are at least four different versions of the controller. For the Milight case this can be handled well by providing different device types and I guess it can be done similar for IWY, e.g. provide a device type for DualWhite bulbs (with Milight it does not make much sense to mix RGB and Dual-White bulbs in a single zone, btw.)
Regarding the special features like night mode and disco mode I agree this is perhaps less important. However, it would be nice to provide some Actions which will allow users to use RGB bulbs as sort of visual feedback as part of their rules, e.g. “If a new e-mail has been received then flash RGB lamp1”.
"It always takes longer than you expect, even when you take into account Hofstadter's Law.", Hofstadter's Law
-
I did a quick review. I like the new structure and will give it a try later.
Here is a shortcut to see commit changes"It always takes longer than you expect, even when you take into account Hofstadter's Law.", Hofstadter's Law
-
I just checked out the code, and it looks great!
i really like that it is split up in different file’s. That makes everything a lot clearer
But i’m wont have a lot time next couple of weeks to work on it…
Normal work doesn’t seem to stop for these nice projects -
This post is deleted!
-
First of all, nice work
I used your plugin with some code & a pcb that I designed a while ago to connect my cheap ebay rgb ledstrips to my pimatic installation using a esp8266 wifi chip. Basically, I implemented the wifi370 protocol on the esp8266 and used PWM outputs of the chip to drive the ledstrip. Therefore I was able to use your plugin without any modifications, which is nice.
A demo video here: http://youtu.be/MzmGHIzuEzY
Once I get some more time I’ll write up a blogpost with more detailed info on the PCB/esp8266 part. Code is up on github here if anyone is interested in esp8266 stuff.
Only thing in the plugin that I can think of that could use improvement is better touchscreen support for the color picker. Currently you have to drag the dot or the slider, clicking on a certain spot doesn’t work (tested on windows (phone) and android (chrome))
(Personally I like the Dummy3 option as proposed by Pimagical - although it has no ‘white’ option - it seems to be most straightforward and easy to use (no popup)) -
Thats strange:
The config says “Error: connection timeout” but i just added the device to my gui and its working. -
@auspex-nl Wow that is pretty cool. I will order an esp8266 and try it on my own.
@thymian “Error: connection timeout” means that a command to the light device was running into an timeout. This could be caused due to network issues or because the device is simply switch off. But I saw also that this error often appears during the start of pimatic, you can consider this as a bug. I will try to fix it soon.