[Solved] New plugin Luxtronik2 - error: Unexpected token =

---

Hi

I’m trying to write a plugin for Luxtrinic heatpumps by usind this library.
https://github.com/coolchip/luxtronik2

My plugin code can be found in this repository here: https://github.com/bakito/pimatic-luxtronik2

In my development environment with Ubuntu the plugin works fine. But when I install it on the raspberry pi I get an error while loading my plugin.

pimatic version: 0.9.39
node version: v4.6.2
npm version: 2.15.11

Can anyone help me finding the problem?

00:09:46.544 [pimatic] info: Loading plugin: "pimatic-luxtronik2" (0.0.1)
coffee-cache: compiling coffee-script file "luxtronik2-plugin.coffee"...Done
00:09:48.013 [pimatic] error: Unexpected token =
00:09:48.068 [pimatic] debug: SyntaxError: Unexpected token =
00:09:48.068 [pimatic] debug:>    at exports.runInThisContext (vm.js:53:16)
00:09:48.068 [pimatic] debug:>    at Module._compile (module.js:373:25)
00:09:48.068 [pimatic] debug:>    at Object.Module._extensions..js (module.js:416:10)
00:09:48.068 [pimatic] debug:>    at Module.load (/home/pi/pimatic-app/node_modules/pimatic-mobile-frontend/node_modules/nap/node_modules/coffee-script/lib/coffee-script/register.js:45:36)
00:09:48.068 [pimatic] debug:>    at Function.Module._load (module.js:300:12)
00:09:48.068 [pimatic] debug:>    at Module.require (module.js:353:17)
00:09:48.068 [pimatic] debug:>    at require (internal/module.js:12:17)
00:09:48.068 [pimatic] debug:>    at module.exports (/home/pi/pimatic-app/node_modules/pimatic-luxtronik2/luxtronik2-plugin.coffee:17:15)
00:09:48.068 [pimatic] debug:>    at PluginManager.loadPlugin (/home/pi/pimatic-app/node_modules/pimatic/lib/plugins.coffee:83:16)
00:09:48.068 [pimatic] debug:>    at /home/pi/pimatic-app/node_modules/pimatic/lib/plugins.coffee:485:25
00:09:48.068 [pimatic] debug:>    at tryCatcher (/home/pi/pimatic-app/node_modules/pimatic/node_modules/bluebird/js/release/util.js:16:23)
00:09:48.068 [pimatic] debug:>    at Promise._settlePromiseFromHandler (/home/pi/pimatic-app/node_modules/pimatic/node_modules/bluebird/js/release/promise.js:512:31)
00:09:48.068 [pimatic] debug:>    at Promise._settlePromise (/home/pi/pimatic-app/node_modules/pimatic/node_modules/bluebird/js/release/promise.js:569:18)
00:09:48.068 [pimatic] debug:>    at Promise._settlePromiseCtx (/home/pi/pimatic-app/node_modules/pimatic/node_modules/bluebird/js/release/promise.js:606:10)
00:09:48.068 [pimatic] debug:>    at Async._drainQueue (/home/pi/pimatic-app/node_modules/pimatic/node_modules/bluebird/js/release/async.js:138:12)
00:09:48.068 [pimatic] debug:>    at Async._drainQueues (/home/pi/pimatic-app/node_modules/pimatic/node_modules/bluebird/js/release/async.js:143:10)
00:09:48.068 [pimatic] debug:>    at Immediate.Async.drainQueues [as _onImmediate] (/home/pi/pimatic-app/node_modules/pimatic/node_modules/bluebird/js/release/async.js:17:14)
00:09:48.068 [pimatic] debug:>    at processImmediate [as _immediateCallback] (timers.js:383:17)

unexpected token = when compiling coffescript of your plugin. Sounds like a syntax error in your coffeescript to me. maybe check luxtronik2-plugin.coffee:17:15 https://github.com/bakito/pimatic-luxtronik2/blob/master/luxtronik2-plugin.coffee#L17. However the code there looks fine at a glance but maybe some wrong indentation or brackets further down in the code.

said in New plugin Luxtronik2 - error: Unexpected token =:

Can anyone help me finding the problem?

As @thex pointed out the problem is caused by requiring the luxtronilk2 module, but there is nothing wrong with your code. The actual guilty is a default parameter in the luxtronik function at https://github.com/coolchip/luxtronik2/blob/master/luxtronik.js#L19. As far as I understand this, the problem is that default parameters are not valid ECMAScript prior to version ES6. Coffeescript currently only supports ES5, however. To get around this you can do one of the following:

• convince the author to make his code coffeescript-friendly (I have filed an issue for that)
• use a tool like babel to transpile the package code to ES5

Of course, there may be other solutions I haven’t thought about. Personally, I’d avoid forrking the project to as this will creat an additional maintainance burden for you.

EDIT: I’ve submitted a pull request on your project with typo fixes.

https://github.com/coolchip/luxtronik2/issues/1

Actually, the luxtronic package has some more issues which I have tried to fix as far as I could test this (I have no heat pump to test with). A pull request is pending for that. Meanwhile you can trial my changes using “mwittig/luxtronik2” as part of package dependencies.

https://github.com/coolchip/luxtronik2/pull/2

Thank you very much for your help.
And for the pull request with the documentation fixes

In the meantime version 0.0.2 of the luxtronik2 library was released. In this version, the default parameter was removed.
Now the plugin works also on my raspberry pi environment.

@bakito said in New plugin Luxtronik2 - error: Unexpected token =:

Now the plugin works also on my raspberry pi environment.

That’s great! Note, however, my pull request will fix some issues with error handling. You may see an unexpected exception causing pimatic to exit when the connection to the heat pump fails for some reason. @coolchip, the author of luxtronik2 has promised to review my PR tommorrow. So there is likely a new version 0.0.3 to be released soon.