[Solved] shell presence sensor - error getting attribute value

---

Hey,

as in my last post, I’m trying to integrate my sqeezeboxes into pimatic. Rules for controll are working now, but my shellpresence sensor does not.
I have written a script to return 0 or 1 depending on status and this is working in console:

pi@raspberrypi:~ $ /home/pi/pimatic-app/scripte/squeezebox.sh unten ping
0

But when using it as a shellPresenceSensor it does not:

error [pimatic-shell-execute,ShellPresenceSensor]: Error getting attribute value squeezebox-unten-ping.presence: undefined
error [pimatic-shell-execute]: [ShellPresenceSensor#squeezebox-unten-ping] Error: Command failed: /bin/sh -c "/home/pi/pimatic-app/scripte/squeezebox.sh unten ping"
/bin/sh: 1: /home/pi/pimatic-app/scripte/squeezebox.sh unten ping: not found

    {
      "command": "\"/home/pi/pimatic-app/scripte/squeezebox.sh unten ping\"",
      "interval": 60,
      "id": "squeezebox-unten-ping",
      "name": "Squeezebox unten",
      "class": "ShellPresenceSensor"
    }

I also tried without \" (so no " in device editor) in the command line, but same effect. Does anyone know where I did something wrong? Thanks in advance.

@Anduril said in shell presence sensor - error getting attribute value:

I also tried without " (so no " in device editor) in the command line, but same effect. Does anyone know where I did something wrong? Thanks in advance.

The error message “not found” is returned if the command is given with escaped quotes \" which is wrong in this context. Just provide the command without quotes and report which error message you get. Most likely it is the execution of shell script failing at some point.

well I tried without those " and it some kind of works. It give an error when saving the device (with squeezebox powered off):

error [pimatic-shell-execute,ShellPresenceSensor]: Error getting attribute value squeezebox-unten-ping.presence: undefined
error [pimatic-shell-execute]: [ShellPresenceSensor#squeezebox-unten-ping] Error: Command failed: /bin/sh -c /home/pi/pimatic-app/scripte/squeezebox.sh unten ping

but no error when it is powered on during device saving. Also setting it’s presence to true some times work, but back to false never does.
The script correctly returns 0 or 1:

pi@raspberrypi:~ $ /home/pi/pimatic-app/scripte/squeezebox.sh unten ping
1
pi@raspberrypi:~ $ /home/pi/pimatic-app/scripte/squeezebox.sh unten aus
pi@raspberrypi:~ $ /home/pi/pimatic-app/scripte/squeezebox.sh unten ping
0
pi@raspberrypi:~ $ /home/pi/pimatic-app/scripte/squeezebox.sh unten an
pi@raspberrypi:~ $ /home/pi/pimatic-app/scripte/squeezebox.sh unten ping
1

I could maybe use autoreset, but this would generate quite some error messages in the log. I hope there is another way. Just for completeness I will add the script:

#!/bin/bash

case "$1" in
    unten) IP=192.168.38.102
    ;;
    Bad) IP=192.168.38.109
    ;;
esac

case "$2" in
    an)  curl --silent -d "p0=play&player=${IP}" http://192.168.38.21:9000/status.xml >/dev/null
    ;;
    aus) curl --silent -d "p0=power&p1=0&player=${IP}" http://192.168.38.21:9000/status.xml >/dev/null
    ;;
    ping) curl --silent -d "p0=power&p1=?&player=${IP}"  http://192.168.38.21:9000/status.xml |grep -c "<b>Ein"
    ;;
esac

I got similar problem with shell-execute, but when i do:

 "plugin": "shell-execute",
      "active": true,
      "shell": "/bin/bash"

and then:

"getStateCommand": "snmpwalk -c * -v2c * iso.3.6.1.4.1.17095.3.5.0 | awk '{if ( $4==1 ) print 0; else print 1 }'",

it worked for me.
Maybe it will help.

@kolorek well I don’t really know what your suggestion is. What did you change to make it work?
I did some further test and think the problem is that grep -c does return 1 if one line is found. But if not found, it sends maybe an empty array or some other type that is written as 0, but not identical to the number 0 that is expected by pimatic. As I’m not a linux sepcialist I don’t know if something like that exist, but that’s the only think I could think about.

@Anduril Ok, sorry, i mean that you should write your command without ".
I show you how my config looks like to compare with yours.
my command is in “” and shell in plugin is changed.

just put in config
"command": "your command here",
so in your config i think that should be:

"command": "/home/pi/pimatic-app/scripte/squeezebox.sh unten ping",
and you should change shell in plugin section to:
"shell": "/bin/bash"

It is already in a format like yours:

    {
      "command": "/home/pi/pimatic-app/scripte/squeezebox.sh Bad ping",
      "interval": 10000,
      "id": "squeezebox-bad-ping",
      "name": "Squeezebox Bad",
      "class": "ShellPresenceSensor",
      "autoReset": true,
      "resetTime": 30000
    }

I now tried with the autoreset and will see if it will log lots of errors. But still I don’t understand why the output of grep -c is not recognized when being 0

@Anduril What is your output in linux console of:
/home/pi/pimatic-app/scripte/squeezebox.sh unten ping
but when you delete everything after |

so show the output when in script line looks like
ping) curl --silent -d "p0=power&p1=?&player=${IP}" http://192.168.38.21:9000/status.xml

the output of that curl is a complete xml file with a rather long content. I did some other tries and managed to get it to work.
I changed the way my script gives back the response of the curl call. Originaly I directly used the output of grep -c, which did not work in case of 0. Now I added a if statement to check if it’s 1, then echo 1 and else echo 0.
In case someone else needs the script, here is it in complete:

#!/bin/bash


case "$1" in
    unten) IP=192.168.38.102
    ;;
    Bad) IP=192.168.38.109
    ;;
esac

case "$2" in
    an)  curl --silent -d "p0=play&player=${IP}" http://192.168.38.21:9000/status.xml >/dev/null
    ;;
    aus) curl --silent -d "p0=power&p1=0&player=${IP}" http://192.168.38.21:9000/status.xml >/dev/null
    ;;
    ping)  detect=$( curl --silent -d "p0=power&p1=?&player=${IP}"  http://192.168.38.21:9000/status.xml |grep -c "<b>Ein")
			if [ "$detect" = 1 ];
				then
				echo "1"
				else
				echo "0"
			fi
    ;;
esac