[Implemented] Receives messages (Telegram)

---

`/pimatic-app/node_modules $ npm install pimatic-telegram@1.0.8
npm ERR! Linux 4.4.38-v7+
npm ERR! argv “/usr/local/bin/node” “/usr/local/bin/npm” “install” "pimatic-telegram@1.0.8"
npm ERR! node v4.4.5
npm ERR! npm v2.15.5
npm ERR! code EPEERINVALID

npm ERR! peerinvalid The package pimatic@0.9.37 does not satisfy its siblings’ peerDependencies requirements!
npm ERR! peerinvalid Peer pimatic-amazing-dash-button@0.9.11 wants pimatic@>=0.8.0 <1.0.0
npm ERR! peerinvalid Peer pimatic-cron@0.8.8 wants pimatic@>=0.8.0 <1.0.0
npm ERR! peerinvalid Peer pimatic-denon-avr@0.9.3 wants pimatic@>=0.8.0 <1.0.0
npm ERR! peerinvalid Peer pimatic-fritz@0.5.3 wants pimatic@>0.8.91 <1.0.0
npm ERR! peerinvalid Peer pimatic-iframe@0.2.0 wants pimatic@>=0.8.0 <1.0.0
npm ERR! peerinvalid Peer pimatic-ifttt@0.1.1 wants pimatic@0.8.*
npm ERR! peerinvalid Peer pimatic-mail@0.8.6 wants pimatic@>=0.8.0 <1.0.0
npm ERR! peerinvalid Peer pimatic-metar-weather@0.9.1 wants pimatic@>=0.9.0 <1.0.0
npm ERR! peerinvalid Peer pimatic-mobile-frontend@0.9.11 wants pimatic@0.9.*
npm ERR! peerinvalid Peer pimatic-netatmo@0.0.8 wants pimatic@>=0.8.0 <1.0.0
npm ERR! peerinvalid Peer pimatic-openweather@0.9.3 wants pimatic@>=0.8.0 <1.0.0
npm ERR! peerinvalid Peer pimatic-ping@0.9.5 wants pimatic@>=0.8.0 <1.0.0
npm ERR! peerinvalid Peer pimatic-shell-execute@0.9.8 wants pimatic@0.9.*
npm ERR! peerinvalid Peer pimatic-sunrise@0.8.7 wants pimatic@>=0.8.0 <1.0.0
npm ERR! peerinvalid Peer pimatic-sysinfo@0.9.4 wants pimatic@0.9.*
npm ERR! peerinvalid Peer pimatic-telegram@1.0.8 wants pimatic@>=0.9.*
npm ERR! peerinvalid Peer pimatic-z-way@1.4.2 wants pimatic@>=0.8.0 <1.0.0

npm ERR! Please include the following file with any support request:
npm ERR! /home/pi/pimatic-app/node_modules/npm-debug.log
`

And now???

@Swen said in Receives messages (Telegram):

npm ERR! peerinvalid Peer pimatic-ifttt@0.1.1 wants pimatic@0.8.*

It should work though. The error messages are caused by pimatic-ifttt which is not officially support with pimatic 0.9

@Dan said in Receives messages (Telegram):

you are corrrect. I have found the issue, javascript in two .js files is incompatible. I have created a workaround, but will do additional testing on my production box first before releasing a fix.

Perhaps you can run your own for of telebot for now until pimatic support node v6. You can use the fork for without publishing your own release of it as follows:

"telebot": "git+htts://github.com/SenTzu01/telebot.git"

You can also refer to a specific commit or branch of your fork. See https://docs.npmjs.com/files/package.json#git-urls-as-dependencies

@Dan Rather than modifying the telebot source code another approach is to transform the code using babel. This way, your fork will be easier to maintain.

• add a build procedure (using gulp / grunt) to cross-complile the stuff using babel to plain old javascript
• place the resulting files in a build directory
• set “main” entry to the build directory

https://github.com/babel/babel

For gulp there is a plugin which make it very easy to do this: https://www.npmjs.com/package/gulp-babel

@mwittig As always, thanks for your wisdom I’ll have a look tomorrow, this seems to be a better solution indeed. I may need a few extra pointers, but will contact you in chat for that.
Bit stupid I failed to load node v4 on my dev box, else I would have found the issue in testing…

Thanks,

Dan

@Andi-Tudor, @Sven and others,
As far as I have been able to test the issue seems to have been resolved by downgrading the js spec for one of the dependencies. Currently release 1.1.1 is available, which works as expected.
People who have not upgraded to 1.1.0 can simply upgrade. If you have upgraded and ended up with a non-working version of Pimatic-Telegram you can upgrade, or alternatively clean your installation first:

• stop Pimatic if daemonized (execute “sudo service pimatic stop”)
• in your <pimatic-app>/node_modules folder execute “rm -rf pimatic-telegram”
• start Pimatic in console mode: “<pimatic-app>/node_modules/pimatic/pimatic.js” (this will automatically re-install pimatic-telegram, provided you have not removed the plugin from your config.json file)
• If the plugin was not installed automatically, you can do so by installing it through the plugins webpage

-if all is well (absence of the error “Unexpected token {” after loading plugin Pimatic-Telegram) you can stop the console mode, and start the pimatic daemon again: sudo service pimatic start

Of course, the known issue re upgrading old rules to the new syntax remains. Please read the documentation and familiarize yourself with the functionality changes.

My sincere apologies for any caused inconvenience.

thx @dan for your nice codework!

i suggest to move the topic to the feature implemented section.
all further communication should be done here https://forum.pimatic.org/topic/2616/new-plugin-for-telegram/ or on any new thread on that topic

Good morning all,

first off all thank you @Dan for a really good plugin, i think this will take the functionality of Pimatic to a higher level!

I updated the plugin from .08 to the latest (.11 i think) and it responds well to my secret and the “help” message. However when i send the “list devices” message (or any other ‘default’ message) i get no response back??

What could be the problem here??

EDIT*)
I also see a “Rule commands:” in the responses but i do not see anything about this in the documentation, is this WIP?

@Stokstaart Morning !

I just retested on my prod box (this one has the plugin from the repository, just like you).

‘help’ -> works like a charm
’list devices’ -> works like a charm
’get device <device name>’ -> works like a charm, but I will improve the description of the command - you need to add the device name or id for this one
’get all devices’ -> seems to have an issue, I’ll look into this asap.
‘keyword’ -> defined in my ruleset as predicate ‘telegram received “keyword”’ -> works like a charm executing a rule

Commands under “Rule commands” will become available, after you add rules with the “telegram received” predicate!

Thanks @Dan for that explanation!

Unfortunately the “list devices” does not work for me, anything i could do to help/bughunt??

(please ignore the timeout message, i send this message to display the plugin isn’t responding to the message…)

@Dan First of all thanks for this awesome work! Goed bezig

Second I experience the same issue as Stokstaart does.

@rikki78 and @stokstaart

Do you have a large amount of devices in your environment like a boss

I have just found the max allowed string length for Telegram messages is 4096 chars, making this not a bug but a feature

• ‘get all devices’ :On my prod with large amount of devices: Generated message is 4554 chars -> fails
• ‘list devices’: List is just ‘small enough’ to let the ‘list devices’ command come up with a message 3476 chars -> success
• ‘get all devices’: On dev with small number of devices: 362 chars -> success

I will implement a fix for this, breaking up larger messages in chucks, and send those piece-meal

Dan

@Dan Thanks for your quick response and the effort you are putting into this!

Looking forward to the update but like i said, for me it’s already a game changer

I totally agree with Stokstaart. For me it is a nice to have. The features already implemented and working are the ones I will use mainly.

I dont’t think a messenger should be used as a full-blown CLI for pimatic.

Executing actions on a device and quering its state would be enough for me. It would be nice, however, to be able to specficy which commands can be executed on which devices. A simple white-listing approach using regex patterns may do.

@mwittig Agree, I am not intending to implement interactive CLI functionality beyond this.
Sending device commands should already be possible (Just haven’t documented yet)
Sending commands to execute rules is also already possible.
Querying state can be done with get device <device name>

I will limit the output on the list devices and get all devices commands to just show state, but will still need to ensure messages stay within the Telegram API limits (4096).
commands <-> devices whitelisting I will look into

The bug has been fixed. Furthermore I have removed the “get all devices” command as it is redundant with the list devices and get device commands for a large part. Details and status can be retrieved with get device <device_name | device_id> anyway

Ok nice feature…
that was what i meant with authentication…

as above said : all further communication should be done here https://forum.pimatic.org/topic/2616/new-plugin-for-telegram/ or on any new thread on that topic

thx!