Travis CI builds of fork not passing

---

I have forked the pimatic repository in my github account. Everytime i push my changes, the Travis CI build starts automatically, but i doesn’t pass.
The error doesn’t come from my changes, though. See https://travis-ci.org/michbeck100/pimatic/builds/141443469 for example.

  1) pimatic startup should startup:
     Uncaught Error: spawn ./node_modules/pimatic/ppm.js ENOENT
    at exports._errnoException (util.js:873:11)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:178:32)
    at onErrorNT (internal/child_process.js:344:16)
  
  2) pimatic #isDeviceInConfig() should find actuator in config:
     TypeError: Cannot read property 'match' of undefined
    at getAssertionExpression (node_modules/cassert/index.js:43:16)
    at assert (node_modules/cassert/index.js:27:18)
    at Context.<anonymous> (test/pimatic-test.coffee:88:7)

The same error occurs when running the tests locally.

Does any anyone have a clue? Maybe @leader21 or @sweetpi or @mwittig ?

I did also analyze this error when running locally. In line 355 of plugins.coffee

        ppmBin = './node_modules/pimatic/ppm.js'

can’t work because there is no such directory node_modules/pimatic when pimatic is checked out from github. I have no clue why the original builds of pimatic (at https://travis-ci.org/pimatic/pimatic) are working.

To reproduce just do

git clone https://github.com/pimatic/pimatic.git
cd pimatic
npm install
npm test

just opened an issue on git so this won’t “get lost”.
am sure sweetpi or mwittig will have a look soon

@leader21 Thanks

@michbeck100 Your branches are behind the mainstream branches. Resync your fork and your problem should be gone.

@mwittig Can you tell which commit fixed this issue?

@michbeck100 Sorry, I can’t as I haven’t fixed it. However, rebasing your branches should not be an issue. This is the recipe I use (example for master branch)

# Add the remote, call it "upstream":

git remote add upstream https://github.com/whoever/whatever.git

# Fetch all the branches of that remote into remote-tracking branches,
# such as upstream/master:

git fetch upstream

# Make sure that you're on your master branch:

git checkout master

# Rewrite your master branch so that any commits of yours that
# aren't already in upstream/master are replayed on top of that
# other branch:

git rebase upstream/master

# If you've rebased your branch onto upstream/master you may need to force the push in 
# order to # push it to your own forked repository on GitHub. 
git push -f origin master

@mwittig my branches were up to date all the time. Thats not the problem.

@michbeck100 Your master is 21 commits behind. Note beyond, the pimatic v0.9x branch is no longer usedAh, ok. Seems like you have synced your fork yesterday. Sorry.
Anyhow, travis build on master runs fine. So if you’r in sync your should work, too.

https://travis-ci.org/pimatic/pimatic

@mwittig If i look at https://github.com/michbeck100/pimatic/tree/master it says

This branch is 21 commits ahead of pimatic:master.

Ahead means i am not behind. And my last commit was https://github.com/michbeck100/pimatic/commit/8f3e18f38385ebe24d0da2a3096f941113241722 which was a sync of upstream pimatic.

I don’t see whats wrong with that?

@michbeck100 So, what your working branch then? (see also my edit on the previous post)

@mwittig Just have a look at my travis build history: https://travis-ci.org/michbeck100/pimatic/builds There’s also a build of the master branch, which didn’t work either.

@michbeck100 Maybe there are different settings in Travis? At https://travis-ci.org/michbeck100/pimatic/settings i can set some environment variables and limit the concurrent jobs. I guess that @sweetpi has access to these settings for pimatic?

@mwittig I think i found the error. The travis-before-install script in pimatic/install isn’t working for the newer travis builds.

#!/bin/sh
pwd -P
cd ../..
mv pimatic node_modules
cd node_modules/pimatic
pwd -P
sudo apt-get install build-essential
npm install sqlite3

Theres no sudo available anymore. And the cd …/… doesn’t work either.
Here’s the fixed version:

#!/bin/sh
pwd -P
cd ..
mkdir node_modules
mv pimatic node_modules/
cd node_modules/pimatic
pwd -P
npm install sqlite3

I fixed it in my fork and the build passes now: https://travis-ci.org/michbeck100/pimatic/builds/141585034

But i’m not sure if the change can be merged to upstream, maybe its not working anymore then? I will create a PR anyway and let it be reviewed.

Oh, and i removed

sudo apt-get install build-essential

because build-essential is already included in the travis build environment OOB. (https://docs.travis-ci.com/user/trusty-ci-environment/#Compilers-%26-Build-toolchain)

PR created: https://github.com/pimatic/pimatic/pull/942

@michbeck100 Strange enough, the master build work without these mods. Last build executed successfully 2 days ago.

@mwittig I know. Maybe it some old version of the travis build worker? I have no idea.

Seems to be still working: https://travis-ci.org/pimatic/pimatic/builds/141586831