[Solved] Shell Execute with double quotes
Hi,
I’m trying to get pimatic to send telegram messages and for this i need to start this:
/home/pi/tg/bin/telegram-cli -k tg-server.pub -W -e “msg User Message”
and with shell-execute I have to put all this in quotes like this:
“/home/pi/tg/bin/telegram-cli -k tg-server.pub -W -e “msg User Message””
But this doesnt work, I tried to escape the quotes like this:
"/home/pi/tg/bin/telegram-cli -k tg-server.pub -W -e “\msg User Message”"
but it doesnt work
Can someone give me a hint?
Your complete rule line should be something like:
"rule": "if temperature of esp12-kamer-temperatuur was not updated for 15 minutes then execute \"sudo telegram-cli -W -e \\\"msg USER The room temperature variable has not been updated during 15 minutes\\\"\"",
Works fine for me.
@theslashy said:
“/home/pi/tg/bin/telegram-cli -k tg-server.pub -W -e “\msg User Message””
Don’t the \ escape character has to be in front of each character which needs to be escaped
“/home/pi/tg/bin/telegram-cli -k tg-server.pub -W -e \“msg User Message\””
this should end up in the config file like @Harry-van-der-Wolf wrote above
I never used this in pimatic but its a guess
some programms also allow single quotes
“/home/pi/tg/bin/telegram-cli -k tg-server.pub -W -e 'msg User Message' ”ok, it seems like i have some serious issues with the shell-execute
i made a script with this in it:
#!/bin/bash
/home/pi/tg/bin/telegram-cli -k tg-server.pub -W -e “msg Target Message”
When i execute the script it works, i receive the message.
Then i made a rule when a button is pressed it should execute the script:
“rule”: “if KellerPC starten is pressed then execute “sudo /home/rudi/wa_scripts/tg2.sh””,
But absolutely nothing happens…I see a little toast saying “done” but that’s it…
Ok more news:
When i put something completely simpel in the script like a “mkdir TEST” everything works…
@theslashy said:
“rule”: “if KellerPC starten is pressed then execute “sudo /home/rudi/wa_scripts/tg2.sh””
You need to escape the quotes around the executecommand.
"rule": "if KellerPC starten is pressed then execute \"sudo /home/rudi/wa_scripts/tg2.sh\""
And make sure you sure the right double quotes. The double quotes in your text were not the right ones
my rule now looks like this:
“rule”: “if button-pcwake is pressed then execute “/home/pi/tg2.sh””
and in the script tg2.sh is the following content:
#!/bin/bash
cd /home/pi/
mkdir TEST
everything works, the Direktory TEST is created.
Then i change nothing in pimatic but in the script i remove the lines and enter for example this:
#!/bin/bash
/home/pi/tg/bin/telegram-cli -k tg-server.pub -W -e “msg User Message”
Nothing happens
What do you mean my double quotes are the wrong ones??
W.r.t. to the double quotes: The: “hanging” comma’s when starting a line and “standing” commas to close it. If I put it in a code format you see it more clearly “rule” versus "rule".
But I see that the forum is doing that so don’t worry about that one.
Anyway: that would not work either in a script.
again: you have to escape your rule like mentioned a couple of times. Your script might work but your rule can’t simply work.
"rule": "if button-pcwake is pressed then execute "/home/pi/tg2.sh""
will never work!
Use:
"rule": "if button-pcwake is pressed then execute \"/home/pi/tg2.sh\""
Ok, so I changed everything as you say. just to show the situation right now:
Rule in Pimatic(i created the rule in the GUI not in the config.json):
{
"id": "test",
"name": "test",
"rule": "if button-pcwake is pressed then execute \"/home/pi/tg2.sh\"",
"active": true,
"logging": true
}
The Script tg2.sh contains:
#!/bin/bash
cd /home/pi/
mkdir TEST
And it works. When I press the Button the Directory TEST is created, all good.
Then i edit the Script tg2.sh, I don’t edit the rule.
The Script then contains:
#!/bin/bash
/home/pi/tg/bin/telegram-cli -k tg-server.pub -W -e "msg User Message"
So the rule is not affected, it is not changed but then it doesn’t do anything…
Perhaps I’m being dumb here but i just don’t get it
Now I understand. I had the same when starting with telegram (looong ago) but I was too focused on the rule and the quotes.
telegram has a config per user. It means that when you execute telegram and configure telegram you do that as user pi or some other “normal” user.
When executing a rule from pimatic you do that as user root. User root needs its own (identical) configuration and currently telegram is not configured for user root and does not know that “User” in your script.
You have 2 options:
"rule": "if button-pcwake is pressed then execute \"sudo pi /home/pi/tg2.sh\"",The sudo command lets you execute a command as another user. If specified without a user it will be user root. When specified with a user it will be done via that user. If you are user root it will work automatically. If you do that from any other user to any other user you have to specify a password.
Shit you got me 
didn’t even remotely think of that, was too focused on the quotes.
it works now with:
"rule": "if button-pcwake is pressed then execute \"sudo -u pi /home/pi/tg2.sh\""
Thank you very much!!
what is the output if you trigger the script from the console?
Edit:
…ok think this is solved now?
@thex said:
the output if you trigger the script from the console?
Edit:
…ok think this is solved now?
Yes it’s solved!
hi guys,
i tried:
"id": "temperatur",
"name": "TemperaturPi",
"class": "ShellSensor",
"attributeName": "temperatur",
"attributeType": "number",
"attributeUnit": "°C",
"command": "sudo sshpass -p [raspberrypassword] ssh -o StrictHostKeyChecking=no [raspberryuser]@[raspberryip] 'vcgencmd measure_temp | awk -F 'temp=' '{print $NF}' | awk -F \"'C\" '{print $1}''",
"interval": 120000
},
but get an error:
error [pimatic-shell-execute]: [ShellSensor#systemp] Error: Command execution failed with exit code 2 (Error: Command failed: /bin/sh: 1: Syntax error: Unterminated quoted string)
i checked: http://bernhardhaeussner.de/odd/json-escape/ but cant find a mistake
could you please help me