Sunrise and Sunset plugin
A rule like ‘when its after <vars>.sunrise then …’ should work independent of the formatting.
What kind of sunrise rules do you use that don’t work anymore?
In node 13 this problems seems to be solved.
If this double formatting doesn’t work for you, there’s another way to solve this with change of the sunrise module and use a time formatting library.
Is not complex but is is a local hack.
The rule that does not work for example is:
When:
[every 1 minute and [it is after $sunset_plus_1h or before $sunrise_plus_1h]] and terr_heat_auto_sw is on and $aut_terr_heat = 1 and eg-pms2-lan_s02 is present
Then:
turn Heizstab off after 5 seconds and set $aut_terr_heat = 0 after 5 seconds and set $messages to “Heizung im Terrarium ausgeschaltet.” after 5 seconds
The variable $sunset_plus_1h has the following expression: timeFormat(timeDecimal($sunrise-device.sunset)+1)
So it generates a time without am and pm inside. So $sunrise-device.sunset=5:39:59 AM, but $sunise_plus_1h=06:39:59
So i think this rule will switch off my device 6:39:59 AM and not 18:39:59 (6:39:59 PM)
Ok, i understand.
The rule action handler is not using string comparison but uses the date value (number of millisecond since midnight January 1, 1970 UTC) to compare.
The rules could work and the AM/PM is ‘just’ a display format issue.
Did you already test the a rule if its acting on the right moment or do you have to wait till PM ?
Is this 24h format issue only a pimatic-sunrise problem or is the hole pimatic involved?
I am asking because when i restart pimatic the timestamp in the daemon-log is in 24h format.
I’m not sure but it seems a nodejs problem in the standard date lib
When you use date format libraries like moment (is used in the logger) there’s no problem.
Using a date format module in sunrise is a solution for this problem.
If you want and can update a plugin module i can provide a solution. You must edit it yourself in your own system.
OK lets try
In a command line terminal you go to directory /home/pi/pimatic-app/node_modules/pimatic-sunrise
Edit the file sunrise.coffee with nano or whatever you want with the 2 changes below.
Save the file and restart Pimatic.
Change the following
line 95
return Promise.resolve @_transformTimezone(@eventTimes[attribute.name]).toLocaleTimeString()
into
return Promise.resolve moment(@_transformTimezone(@eventTimes[attribute.name])).format('HH:mm:ss')
and line 105
@emit attribute.name, @_transformTimezone(@eventTimes[attribute.name]).toLocaleTimeString()
into
@emit attribute.name, moment(@_transformTimezone(@eventTimes[attribute.name])).format('HH:mm:ss')
It is reformatting the values of the sunrise attributes. You should test the rules behaviour
OK this worked for me, thanks
@bertreb Thank you it worked for me too.
