New Plugin for Denon/Marantz AVRs
I removed the plugin completely and restarted pimatic. Normally it should have installed it bu it did not (saw a 503 from the update server in the log).
I then installed it again from the plugins section of the web-frontend. This time it worked.
However the GUI was seriously broken and I had to clear all caches in my browsers.
@leader21 said in New Plugin for Denon/Marantz AVRs:
here it is running but having an issue too
[DenonAvrMasterVolume#denon-zone2-switch] Error: [Error: Missing or invalid interval parameter]
Fixed in pimatic-denon-avr@0.9.9
"It always takes longer than you expect, even when you take into account Hofstadter's Law.", Hofstadter's Law
Hi,
I’m having an error quite a long time with the VolumeState of my Denon AVR. It is not a big problem but i just want to mention. The Plugin is working fine and all functions are working as expected, thanks for your work @mwittig, but my log-File is giving me some errors.
If the Denon AVR is offline and you haven’t activated the option network control the following error occurs:
Unhandled rejection Error: Expected variable Denon-Volume-Status.volume to have a numeric value.
at /home/pi/pimatic-app/node_modules/pimatic/lib/variables-ast-builder.coffee:111:17
at tryCatcher (/home/pi/pimatic-app/node_modules/pimatic/node_modules/bluebird/js/release/util.js:16:23)
at Promise._settlePromiseFromHandler (/home/pi/pimatic-app/node_modules/pimatic/node_modules/bluebird/js/release/promise.js:512:31)
at Promise._settlePromise (/home/pi/pimatic-app/node_modules/pimatic/node_modules/bluebird/js/release/promise.js:569:18)
at Promise._settlePromise0 (/home/pi/pimatic-app/node_modules/pimatic/node_modules/bluebird/js/release/promise.js:614:10)
at Promise._settlePromises (/home/pi/pimatic-app/node_modules/pimatic/node_modules/bluebird/js/release/promise.js:693:18)
at Async._drainQueue (/home/pi/pimatic-app/node_modules/pimatic/node_modules/bluebird/js/release/async.js:133:16)
at Async._drainQueues (/home/pi/pimatic-app/node_modules/pimatic/node_modules/bluebird/js/release/async.js:143:10)
at Immediate.Async.drainQueues [as _onImmediate] (/home/pi/pimatic-app/node_modules/pimatic/node_modules/bluebird/js/release/async.js:17:14)
at processImmediate [as _immediateCallback] (timers.js:383:17)
Unhandled rejection Error: unknown state=""!
@Fabian said in New Plugin for Denon/Marantz AVRs:
If the Denon AVR is offline and you haven’t activated the option network control the following error occurs:
Thanks for reporting and the feedback. I am glad you like it!
Which protocol do you use - HTTP or TELNET (the latter is the default)?
"It always takes longer than you expect, even when you take into account Hofstadter's Law.", Hofstadter's Law
same here however I don’t have it running in debug at the moment and I get this ocassionaly (3x day) even thou my amp is allways on.
20:54:17.033 [pimatic-denon-avr] error: [HttpAppProtocol] [object Object]
20:55:08.304 [pimatic-denon-avr] error: [HttpAppProtocol] AssertionError: level >= 0
Using http with a Marantz
Also one more thing I noticed. For me sometimes the source is not in sync and when I press the last source which was set by pimatic again it seems to surpress the command because it thinks the source is already active. Would be great if it allways sends it out no matter what the last remembered state was.
@mwittig: I’m using the http-protocol. Here is my config:
{
"plugin": "denon-avr",
"host": "192.168.2.12",
"protocol": "HTTP",
"port": 80,
"debug": false,
"active": true
},
{
"id": "Denon-Volume",
"name": "🎚 Lautstärke",
"class": "DenonAvrZoneVolume",
"zone": "MAIN",
"interval": 10,
"volumeDecibel": true,
"maxAbsoluteVolume": 50,
"xAttributeOptions": [
{
"name": "volume",
"displaySparkline": false,
"hidden": true
}
]
},
But i’m also using a curl command to get the volume value. => I just realize that this is unnecessary. 
Because I also could have used the value provided by the above mentioned device: Denon-Volume.volume.
{
"id": "Denon-Volume-Status",
"name": "Denon Volume Status",
"class": "ShellSensor",
"attributeName": "volume",
"attributeType": "number",
"command": "curl -s http://192.168.2.12/goform/formMainZone_MainZoneXmlStatusLite.xml | head -n6 | tail -n1 | sed 's/<MasterVolume><value>//' | sed 's/<\\/value><\\/MasterVolume>//'",
"interval": 5000
},
please let me know if I can help with testing some cases like switching to TELNET protocol or however…
@Fabian Thanks for posting the config. Actually, Denon-Volume-Status is ShellSensor. I think you need to handle the case where the curl command returns no value (as the AVR is offline). I think the following may be help
curl -s http://192.168.2.12/goform/formMainZone_MainZoneXmlStatusLite.xml | head -n6 | tail -n1 | sed 's/<MasterVolume><value>//' | sed 's/<\\/value><\\/MasterVolume>//' | sed -e 's/^$/0/'"It always takes longer than you expect, even when you take into account Hofstadter's Law.", Hofstadter's Law
@thex said in New Plugin for Denon/Marantz AVRs:
same here however I don’t have it running in debug at the moment and I get this ocassionaly (3x day) even thou my amp is allways on.
20:54:17.033 [pimatic-denon-avr] error: [HttpAppProtocol] [object Object]
20:55:08.304 [pimatic-denon-avr] error: [HttpAppProtocol] AssertionError: level >= 0
This is another problem. Thanks for reporting. I’ll look into this asap
"It always takes longer than you expect, even when you take into account Hofstadter's Law.", Hofstadter's Law
@mwittig I’m so emberrassed to made your plugin responsibile for that fault. Sorry for that! I haven’t realized that the error is caused by the shell sensor. First i thougth your suggested solution solves the Problem. But the error is still present. Do you have an other idea?
Thank you again.
@Fabian said in New Plugin for Denon/Marantz AVRs:
I’m so emberrassed to made your plugin responsibile for that fault. Sorry for that!
No worries! Does the suggested change to curl command sequence provide the expected result?
"It always takes longer than you expect, even when you take into account Hofstadter's Law.", Hofstadter's Law
Hi @mwittig,
thank you for your help so far. By now I have changed my config to use the values provided by your plugin. But I’m really interested in a solution.
So your suggestion is working if the receiver is switched on.
pi@raspberrypi:~ $ curl -s http://192.168.2.12/goform/formMainZone_MainZoneXmlStatusLite.xml | head -n6 | tail -n1 | sed 's/<MasterVolume><value>//' | sed 's/<\/value><\/MasterVolume>//' | sed -e 's/^$/0/'
-51.0
If I switch it of than the curl command is excecuted for really long time. So i tried to reduce it to 5 seconds with the additional command (-m 5). But this is leading to no response at all.
pi@raspberrypi:~ $ curl -s http://192.168.2.12/goform/formMainZone_MainZoneXmlStatusLite.xml | head -n6 | tail -n1 | sed 's/<MasterVolume><value>//' | sed 's/<\/value><\/MasterVolume>//' | sed -e 's/^$/0/'
^C
pi@raspberrypi:~ $ curl -s -m 5 http://192.168.2.12/goform/formMainZone_MainZoneXmlStatusLite.xml | head -n6 | tail -n1 | sed 's/<MasterVolume><value>//' | sed 's/<\/value><\/MasterVolume>//' | sed -e 's/^$/0/'
pi@raspberrypi:~ $
I also tried to use an if state but the curl command is exiting every time with error=0 so this is not helping…
So perhaps you have an other idea?
@Fabian said in New Plugin for Denon/Marantz AVRs:
But this is leading to no response at all.
What do you mean by now response at all? Using -m 5 the curl command should terminate, and you should get an error result (exit code other than 0) - or you get a 0 prompted. Most likely, you’ll get the exit code other than 0. You can check with echo $? after command execution. If the command is executed by pimatic-shell-execute the exit code should be handled properly as an error.
In other words, the | sed -e 's/^$/0/is only to handle cases where curldoes not bail out with an error exit code. These are mostly cases where the target service is not available or refused and a HTTP response with a status code other than 200 isis received. Note, it is possible to enforce error handling for these case using the --fail option. See https://superuser.com/questions/590099/can-i-make-curl-fail-with-an-exitcode-different-than-0-if-the-http-status-code-i
"It always takes longer than you expect, even when you take into account Hofstadter's Law.", Hofstadter's Law
Hi @mwittig
I do not get any exit code other than 0. And the sed command is not printing out the 0. Perhaps you have another idea?
Denon off:
pi@raspberrypi:~ $ curl -s http://192.168.2.12/goform/formMainZone_MainZoneXmlStatusLite.xml | head -n6 | tail -n1 | sed 's/<MasterVolume><value>//' | sed 's/<\/value><\/MasterVolume>//' | sed -e 's/^$/0/'
pi@raspberrypi:~ $ echo $?
0
Denon on:
pi@raspberrypi:~ $ curl -s http://192.168.2.12/goform/formMainZone_MainZoneXmlStatusLite.xml | head -n6 | tail -n1 | sed 's/<MasterVolume><value>//' | sed 's/<\/value><\/MasterVolume>//' | sed -e 's/^$/0/'
-42.5
pi@raspberrypi:~ $ echo $?
0
pi@raspberrypi:~ $ curl -m 5 -s http://192.168.2.12/goform/formMainZone_MainZoneXmlStatusLite.xml | head -n6 | tail -n1 | sed 's/<MasterVolume><value>//' | sed 's/<\/value><\/MasterVolume>//' | sed -e 's/^$/0/'
-42.5
Denon off:
pi@raspberrypi:~ $ curl -m 5 -s http://192.168.2.12/goform/formMainZone_MainZoneXmlStatusLite.xml | head -n6 | tail -n1 | sed 's/<MasterVolume><value>//' | sed 's/<\/value><\/MasterVolume>//' | sed -e 's/^$/0/'
pi@raspberrypi:~ $ echo $?
0
pi@raspberrypi:~ $
@Fabian Strange, I am not sure why the sed stuff does not work here. Try the following instead: grep . || echo 0, for example:
curl -m 5 -s http://192.168.2.12/goform/formMainZone_MainZoneXmlStatusLite.xml | head -n6 | tail -n1 | sed 's/<MasterVolume><value>//' | sed 's/<\/value><\/MasterVolume>//' | tee >(read || echo 0)
Regarding the exit code it depends on the shell from a pipelined command, it depends on the setting you have. Apparently, the default is to continue the pipeline on error. As the last command succeeds the exit code is 0. To change that behavior you can use set -o pipeline, for example:
bash -c "set -o pipefail; curl --connect-timeout 5 -s http://192.168.2.12/goform/formMainZone_MainZoneXmlStatusLite.xml --fail | head -n6 | tail -n1 | sed 's/<MasterVolume><value>//' | sed 's/<\/value><\/MasterVolume>//' | tee >(read || echo 0)"
Note, however, this solution only works with bash. It is also a bit odd as it will output 0 even if the exit code is not 0. See the following for a portable solution which runs in a subshell:
(set -e; OUTPUT="$(curl --connect-timeout 5 -s http://192.168.2.12/goform/formMainZone_MainZoneXmlStatusLite.xml --fail)"; echo $OUTPUT | head -n6 | tail -n1 | sed 's/<MasterVolume><value>//' | sed 's/<\/value><\/MasterVolume>//' | sed 's/^$/0/')
"It always takes longer than you expect, even when you take into account Hofstadter's Law.", Hofstadter's Law
@mwittig Thank you so much!!!
The first command is working fine. I’ll try to use it in pimatic now.
Denon off:
pi@raspberrypi:~ $ curl -m 5 -s http://192.168.2.12/goform/formMainZone_MainZoneXmlStatusLite.xml | head -n6 | tail -n1 | sed 's/<MasterVolume><value>//' | sed 's/<\/value><\/MasterVolume>//' | tee >(read || echo 0)
0
Denon on:
pi@raspberrypi:~ $ curl -m 5 -s http://192.168.2.12/goform/formMainZone_MainZoneXmlStatusLite.xml | head -n6 | tail -n1 | sed 's/<MasterVolume><value>//' | sed 's/<\/value><\/MasterVolume>//' | tee >(read || echo 0)
-48.0
Just as information, the second suggested command is even working fine.
Denon off:
pi@raspberrypi:~ $ bash -c "set -o pipefail; curl --connect-timeout 5 -s http://192.168.2.12/goform/formMainZone_MainZoneXmlStatusLite.xml --fail | head -n6 | tail -n1 | sed 's/<MasterVolume><value>//' | sed 's/<\/value><\/MasterVolume>//' | tee >(read || echo 0)"
0
Denon on:
pi@raspberrypi:~ $ bash -c "set -o pipefail; curl --connect-timeout 5 -s http://192.168.2.12/goform/formMainZone_MainZoneXmlStatusLite.xml --fail | head -n6 | tail -n1 | sed 's/<MasterVolume><value>//' | sed 's/<\/value><\/MasterVolume>//' | tee >(read || echo 0)"
-48.0
But the last command to run in a subshell is not working properly. But don’t mind, I’m quiet happy with the first solution! Perhaps I have missunderstood something…
Denon off: (no output)
pi@raspberrypi:~ $ (set -e; OUTPUT="$(curl --connect-timeout 5 -s http://192.168.2.12/goform/formMainZone_MainZoneXmlStatusLite.xml --fail)"; echo $OUTPUT | head -n6 | tail -n1 | sed 's/<MasterVolume><value>//' | sed 's/<\/value><\/MasterVolume>//' | sed 's/^$/0/')
pi@raspberrypi:~ $ (set -e; OUTPUT="$(curl --connect-timeout 5 -s http://192.168.2.12/goform/formMainZone_MainZoneXmlStatusLite.xml --fail)"; echo $OUTPUT | head -n6 | tail -n1 | sed 's/<MasterVolume><value>//' | sed 's/<\/value><\/MasterVolume>//' | sed 's/^$/0/')
Denon on: (Info is not extracted)
pi@raspberrypi:~ $ (set -e; OUTPUT="$(curl --connect-timeout 5 -s http://192.168.2.12/goform/formMainZone_MainZoneXmlStatusLite.xml --fail)"; echo $OUTPUT | head -n6 | tail -n1 | sed 's/<MasterVolume><value>//' | sed 's/<\/value><\/MasterVolume>//' | sed 's/^$/0/')
<?xml version="1.0" encoding="utf-8" ?> <item> <Power><value>ON</value></Power> <InputFuncSelect><value>SAT/CBL</value></InputFuncSelect> <VolumeDisplay><value>Absolute</value></VolumeDisplay> -48.0 <Mute><value>off</value></Mute> </item>
Forked posts about multiple open HTTP connection into a separate topic -https://forum.pimatic.org/topic/3291/solved-denon-avr-multiple-open-http-connections
"It always takes longer than you expect, even when you take into account Hofstadter's Law.", Hofstadter's Law
@thex said in New Plugin for Denon/Marantz AVRs:
20:54:17.033 [pimatic-denon-avr] error: [HttpAppProtocol] [object Object]
20:55:08.304 [pimatic-denon-avr] error: [HttpAppProtocol] AssertionError: level >= 0
I think the issue is due to a wrong setup of the volume device. If you’re still interested in following up on this, please send the device configuration for review. I might also need some debug output at a later point. Thanks
"It always takes longer than you expect, even when you take into account Hofstadter's Law.", Hofstadter's Law